Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register proxy agent using the service account endpoint #1043

Merged
merged 2 commits into from
Mar 27, 2019

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Mar 25, 2019

The proxy server now has a /request-service-account-endpoint that gives an endpoint for a service account.
This endpoint will work with GKE, in case a VM dies and the agent failover to another VM.


This change is Reviewable

The proxy server now has a /request-service-account-endpoint that gives an endpoint for a service account. 
This endpoint will work with GKE, in case a VM dies and the agent failover to another VM.
@k8s-ci-robot k8s-ci-robot requested review from ojarjur and vicaire March 25, 2019 23:01
@IronPan
Copy link
Member Author

IronPan commented Mar 25, 2019

/assign @hongye-sun

Copy link
Contributor

@hongye-sun hongye-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@IronPan
Copy link
Member Author

IronPan commented Mar 27, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8481f41 into master Mar 27, 2019
@IronPan IronPan deleted the IronPan-patch-3 branch May 30, 2019 07:16
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
…kubeflow#1043)

* remove timeout since we moved to default unlimited timeout

* remove old global flag

* fix python lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants