Revert "Register proxy agent using the service account endpoint" #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fdfde54.
|
/assign @rileyjbauer |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test kubeflow-pipeline-e2e-test |
2 similar comments
|
/test kubeflow-pipeline-e2e-test |
|
/test kubeflow-pipeline-e2e-test |
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* Move existing controller to v1alpha2 * Implement v1beta1 controller * Fix test crd path * Add controller test for predictor * Setup webhook for v1beta1 and v1alpha2 * Fix webhook setup * Add api conversion * Patch conversion webhook to crd * Fix the configmap decoding * Fix v1beta1 controller test * Address comments * Add transformer * Transformer support * Fix validate create for http test * Reconcile kfserving ingress * Add license * Add rbac for ingress and svc * Add rbac for ingress and svc * Fix ingress host * Switch to use virtual service * Add conversion test * Add crd conversion test * Add explainer * More conversion test * Add custom predictor defaulter test * Don't use nested inline * Fix transformer and explainer * Set ingress condition * Add ingress asserts * Fix explainer route * Update ksvc traffic targets based on canary traffic split * e2e test to work with v1beta1 * skip gpu test * Fix canary traffic pointer type * Download yq * Add nil check for spec what miss component implementation * Expose podspec on component * Support http url in v1beta1 * fix typo * Update traffic on routespec when canaryPercent is changed * Add canary rollout test * Add explainer test * Address comments * Use tritonserver * Make container name and probe port field optional * Add traffic percent in status * Set xgboost nthread * Fix updates in test * Use default service name for backwards compatibility * Call knative defaulter to avoid diffs during reconcilation * Set SessionAffinity * Check if configured as internal domain
HumairAK
pushed a commit
to red-hat-data-services/data-science-pipelines
that referenced
this pull request
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit fdfde54.
the commit was checked in by accident.
This change is