-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kubernetes_platform): Update kubernetes_platform go package to include imagePullPolicy. #10416
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hi @revit13. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @connor-mccarthy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@@ -26,6 +26,8 @@ message KubernetesExecutorConfig { | |||
repeated PvcMount pvc_mount = 3; | |||
NodeSelector node_selector = 4; | |||
PodMetadata pod_metadata = 5; | |||
// One of Always, Never, IfNotPresent. | |||
string image_pull_policy = 6; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: if this is a stable value set, maybe we can make this an enum instead of string? (I don't have strong opinion on this, feel free to ignore)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chensun I think I'll leave it as a string if that's ok. Also, it seems that in Kubernetes it is defined as a string as well, but I am not sure if it's the same case. Anyway, in the second part of the PR there is a check for the values. Thanks
/approve |
Signed-off-by: Revital Sur <eres@il.ibm.com>
@revit13: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun, Tomcli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…nclude imagePullPolicy. (kubeflow#10416) Signed-off-by: Revital Sur <eres@il.ibm.com>
…nclude imagePullPolicy. (kubeflow#10416) Signed-off-by: Revital Sur <eres@il.ibm.com>
…nclude imagePullPolicy. (kubeflow#10416) Signed-off-by: Revital Sur <eres@il.ibm.com>
…nclude imagePullPolicy. (kubeflow#10416) Signed-off-by: Revital Sur <eres@il.ibm.com>
…nclude imagePullPolicy. (kubeflow#10416) Signed-off-by: Revital Sur <eres@il.ibm.com>
…nclude imagePullPolicy. (kubeflow#10416) Signed-off-by: Revital Sur <eres@il.ibm.com>
Description of your changes:
Part of #9714 and #9980
Update kubernetes_platform go package to include image pull policy. Once this is ready, I will also update the backend driver, compiler, and SDK with this new feature.
Checklist: