Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kubernetes_platform): Update kubernetes_platform go package to include imagePullPolicy. #10416

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

revit13
Copy link
Contributor

@revit13 revit13 commented Jan 21, 2024

Description of your changes:
Part of #9714 and #9980

Update kubernetes_platform go package to include image pull policy. Once this is ready, I will also update the backend driver, compiler, and SDK with this new feature.

Checklist:

Copy link

google-cla bot commented Jan 21, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

Hi @revit13. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@revit13 revit13 changed the title feat(kubernetes_platform): Update kubernetes_platform go package to include image pull policy. feat(kubernetes_platform): Update kubernetes_platform go package to include imagePullPolicy. Jan 21, 2024
@Tomcli
Copy link
Member

Tomcli commented Jan 22, 2024

/ok-to-test

@zijianjoy
Copy link
Collaborator

/assign @Tomcli

/cc @chensun

Copy link
Member

@Tomcli Tomcli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@Tomcli Tomcli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/assign @connor-mccarthy

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@@ -26,6 +26,8 @@ message KubernetesExecutorConfig {
repeated PvcMount pvc_mount = 3;
NodeSelector node_selector = 4;
PodMetadata pod_metadata = 5;
// One of Always, Never, IfNotPresent.
string image_pull_policy = 6;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: if this is a stable value set, maybe we can make this an enum instead of string? (I don't have strong opinion on this, feel free to ignore)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chensun I think I'll leave it as a string if that's ok. Also, it seems that in Kubernetes it is defined as a string as well, but I am not sure if it's the same case. Anyway, in the second part of the PR there is a check for the values. Thanks

@chensun
Copy link
Member

chensun commented Feb 7, 2024

/approve

Signed-off-by: Revital Sur <eres@il.ibm.com>
Copy link

@revit13: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kfp-kubernetes-execution-tests 921a7e8 link false /test kfp-kubernetes-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@Tomcli Tomcli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Feb 7, 2024
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun, Tomcli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit f51dc39 into kubeflow:master Feb 7, 2024
8 of 9 checks passed
roytman pushed a commit to roytman/pipelines that referenced this pull request Feb 14, 2024
…nclude imagePullPolicy. (kubeflow#10416)

Signed-off-by: Revital Sur <eres@il.ibm.com>
stijntratsaertit pushed a commit to stijntratsaertit/kfp that referenced this pull request Feb 16, 2024
…nclude imagePullPolicy. (kubeflow#10416)

Signed-off-by: Revital Sur <eres@il.ibm.com>
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 27, 2024
…nclude imagePullPolicy. (kubeflow#10416)

Signed-off-by: Revital Sur <eres@il.ibm.com>
rimolive pushed a commit to rimolive/data-science-pipelines that referenced this pull request Mar 28, 2024
…nclude imagePullPolicy. (kubeflow#10416)

Signed-off-by: Revital Sur <eres@il.ibm.com>
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 29, 2024
…nclude imagePullPolicy. (kubeflow#10416)

Signed-off-by: Revital Sur <eres@il.ibm.com>
VaniHaripriya pushed a commit to VaniHaripriya/data-science-pipelines that referenced this pull request Sep 23, 2024
…nclude imagePullPolicy. (kubeflow#10416)

Signed-off-by: Revital Sur <eres@il.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants