Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kubernetes_platform): Update kubernetes_platform go package to include ConfigMaps as volumes and as env variables. #10400

Merged
merged 7 commits into from
Feb 9, 2024
Merged

feat(kubernetes_platform): Update kubernetes_platform go package to include ConfigMaps as volumes and as env variables. #10400

merged 7 commits into from
Feb 9, 2024

Conversation

roytman
Copy link
Contributor

@roytman roytman commented Jan 16, 2024 •
edited
Loading

Update kubernetes_platform go package to include ConfigMaps as volumes and as env variables.

Description of your changes:

Part of #9768 , #10155 and #10251

Checklist:

@roytman
Update kubernetes_platform go package to include ConfigMaps as volume…
b0217d9 
…s and as env variables

Signed-off-by: Alexey Roytman <roytman@il.ibm.com>
@google-oss-prow Google OSS Prow
Copy link

Hi @roytman. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow google-oss-prow bot requested review from chensun and gkcalat January 16, 2024 12:45
@Tomcli
Copy link
Member

Tomcli commented Jan 16, 2024

/ok-to-test

Tomcli
Tomcli suggested changes Jan 16, 2024
View reviewed changes
Copy link
Member

@Tomcli Tomcli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @roytman for your PR. I have few change requests in the proto file. Can you update them and regenerate the go package? Thank you.

kubernetes_platform/proto/kubernetes_executor_config.proto Show resolved Hide resolved
kubernetes_platform/proto/kubernetes_executor_config.proto Outdated Show resolved Hide resolved
@google-oss-prow google-oss-prow bot added size/XL and removed size/L labels Jan 16, 2024
Tomcli
Tomcli reviewed Jan 16, 2024
View reviewed changes
kubernetes_platform/proto/kubernetes_executor_config.proto Outdated

message ConfigMapKeyToEnvMap {
// Corresponds to a key of the ConfigMap.
string configmap_key = 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @roytman, can you update the configmap key to config_map_key just to align with your other naming convention.

Suggested change
string configmap_key = 1;
string config_map_key = 1;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, fixed it.

@Tomcli
Copy link
Member

Tomcli commented Jan 16, 2024

Thanks @roytman
/lgtm

/assign @connor-mccarthy

@google-oss-prow google-oss-prow bot added the lgtm label Jan 16, 2024
@Tomcli
Copy link
Member

Tomcli commented Jan 18, 2024

/lgtm cancel

@google-oss-prow google-oss-prow bot removed the lgtm label Jan 18, 2024
@Tomcli
Copy link
Member

Tomcli commented Jan 18, 2024

thanks @roytman
/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jan 18, 2024
@google-oss-prow google-oss-prow bot removed the lgtm label Jan 22, 2024
@roytman
Copy link
Contributor Author

roytman commented Jan 22, 2024

Hi @Tomcli,
I renamed CmAsVolume to ConfigMapAsVolume and CmAsEnv to ConfigMapAsEnv. It looks better in Python implementation.
Please approve.

@Tomcli
Copy link
Member

Tomcli commented Jan 22, 2024

thanks @roytman
/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jan 22, 2024
@Tomcli
Copy link
Member

Tomcli commented Jan 22, 2024

/cc @connor-mccarthy

@Tomcli
Copy link
Member

Tomcli commented Jan 24, 2024

Hi @connor-mccarthy, could you help us review this PR? We want to extend the Kubernetes_platform definition to support more Kubernetes features. Thank you.

@google-oss-prow google-oss-prow bot removed the lgtm label Feb 7, 2024
Tomcli
Tomcli approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@Tomcli Tomcli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Feb 7, 2024
@google-oss-prow google-oss-prow bot removed the lgtm label Feb 7, 2024
Tomcli
Tomcli approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@Tomcli Tomcli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Feb 7, 2024
@google-oss-prow Google OSS Prow
Copy link

@roytman: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kfp-kubernetes-execution-tests f0e93a6 link false /test kfp-kubernetes-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Tomcli
Copy link
Member

Tomcli commented Feb 7, 2024

/assign @chensun

chensun
chensun approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun, Tomcli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 6cc234b into kubeflow:master Feb 9, 2024
8 of 9 checks passed
roytman added a commit to roytman/pipelines that referenced this pull request Feb 14, 2024
@roytman
feat(kubernetes_platform): Update kubernetes_platform go package to i…
30a5058 
…nclude ConfigMaps as volumes and as env variables. (kubeflow#10400)

* Update kubernetes_platform go package to include ConfigMaps as volumes and as env variables

Signed-off-by: Alexey Roytman <roytman@il.ibm.com>

* add ConfigMapKeyToEnvMap

* change config_map_key string

* add list of map

* rename "CmAsVolume" to "ConfigMapAsVolume" and "CmAsEnv" to "ConfigMapAsEnv"

---------

Signed-off-by: Alexey Roytman <roytman@il.ibm.com>
stijntratsaertit pushed a commit to stijntratsaertit/kfp that referenced this pull request Feb 16, 2024
@roytman @stijntratsaertit
feat(kubernetes_platform): Update kubernetes_platform go package to i…
d0ff031 
…nclude ConfigMaps as volumes and as env variables. (kubeflow#10400)

* Update kubernetes_platform go package to include ConfigMaps as volumes and as env variables

Signed-off-by: Alexey Roytman <roytman@il.ibm.com>

* add ConfigMapKeyToEnvMap

* change config_map_key string

* add list of map

* rename "CmAsVolume" to "ConfigMapAsVolume" and "CmAsEnv" to "ConfigMapAsEnv"

---------

Signed-off-by: Alexey Roytman <roytman@il.ibm.com>
@Tomcli Tomcli mentioned this pull request Mar 8, 2024
Merged
This was referenced Mar 10, 2024
Merged
Merged
Closed
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 27, 2024
@roytman @petethegreat
feat(kubernetes_platform): Update kubernetes_platform go package to i…
e84d93a 
…nclude ConfigMaps as volumes and as env variables. (kubeflow#10400)

* Update kubernetes_platform go package to include ConfigMaps as volumes and as env variables

Signed-off-by: Alexey Roytman <roytman@il.ibm.com>

* add ConfigMapKeyToEnvMap

* change config_map_key string

* add list of map

* rename "CmAsVolume" to "ConfigMapAsVolume" and "CmAsEnv" to "ConfigMapAsEnv"

---------

Signed-off-by: Alexey Roytman <roytman@il.ibm.com>
rimolive pushed a commit to rimolive/data-science-pipelines that referenced this pull request Mar 28, 2024
@roytman @rimolive
feat(kubernetes_platform): Update kubernetes_platform go package to i…
fd368d8 
…nclude ConfigMaps as volumes and as env variables. (kubeflow#10400)

* Update kubernetes_platform go package to include ConfigMaps as volumes and as env variables

Signed-off-by: Alexey Roytman <roytman@il.ibm.com>

* add ConfigMapKeyToEnvMap

* change config_map_key string

* add list of map

* rename "CmAsVolume" to "ConfigMapAsVolume" and "CmAsEnv" to "ConfigMapAsEnv"

---------

Signed-off-by: Alexey Roytman <roytman@il.ibm.com>
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 29, 2024
@roytman @petethegreat
feat(kubernetes_platform): Update kubernetes_platform go package to i…
ee0b6af 
…nclude ConfigMaps as volumes and as env variables. (kubeflow#10400)

* Update kubernetes_platform go package to include ConfigMaps as volumes and as env variables

Signed-off-by: Alexey Roytman <roytman@il.ibm.com>

* add ConfigMapKeyToEnvMap

* change config_map_key string

* add list of map

* rename "CmAsVolume" to "ConfigMapAsVolume" and "CmAsEnv" to "ConfigMapAsEnv"

---------

Signed-off-by: Alexey Roytman <roytman@il.ibm.com>
VaniHaripriya pushed a commit to VaniHaripriya/data-science-pipelines that referenced this pull request Sep 23, 2024
@roytman @VaniHaripriya
feat(kubernetes_platform): Update kubernetes_platform go package to i…
0e345a7 
…nclude ConfigMaps as volumes and as env variables. (kubeflow#10400)

* Update kubernetes_platform go package to include ConfigMaps as volumes and as env variables

Signed-off-by: Alexey Roytman <roytman@il.ibm.com>

* add ConfigMapKeyToEnvMap

* change config_map_key string

* add list of map

* rename "CmAsVolume" to "ConfigMapAsVolume" and "CmAsEnv" to "ConfigMapAsEnv"

---------

Signed-off-by: Alexey Roytman <roytman@il.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomcli Tomcli Tomcli approved these changes

@chensun chensun chensun approved these changes

@gkcalat gkcalat Awaiting requested review from gkcalat

@connor-mccarthy connor-mccarthy Awaiting requested review from connor-mccarthy

Assignees

@chensun chensun

@Tomcli Tomcli

@connor-mccarthy connor-mccarthy

Labels
approved lgtm ok-to-test size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roytman @Tomcli @chensun @connor-mccarthy