Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some typos #1038

Merged
merged 2 commits into from
Apr 3, 2019
Merged

Fixed some typos #1038

merged 2 commits into from
Apr 3, 2019

Conversation

thedriftofwords
Copy link
Contributor

@thedriftofwords thedriftofwords commented Mar 25, 2019

Fixed typos / spelling errors
Added a link to Cloud ML Engine runtime versions
Made some formatting (of required / optional) more consistent


This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @thedriftofwords. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@k8s-ci-robot
Copy link
Contributor

Hi @thedriftofwords. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@hongye-sun hongye-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks.

@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 25, 2019

@rileyjbauer
Copy link
Contributor

/ok-to-test

@rileyjbauer
Copy link
Contributor

/test kubeflow-pipeline-e2e-test

1 similar comment
@rileyjbauer
Copy link
Contributor

/test kubeflow-pipeline-e2e-test

Fixed typos / spelling errors
Added a link to Cloud ML Engine runtime versions
Made some formatting (of required / optional) more consistent
@k8s-ci-robot k8s-ci-robot added size/M and removed size/S labels Apr 2, 2019
@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 3, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 443feb7 into kubeflow:master Apr 3, 2019
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants