Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a recursion sample #1016

Merged
merged 37 commits into from
Mar 28, 2019
Merged

Add a recursion sample #1016

merged 37 commits into from
Mar 28, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Mar 22, 2019

This PR is based on #1014


This change is Reviewable

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

Copy link
Contributor

@hongye-sun hongye-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for the quick fix.

@k8s-ci-robot k8s-ci-robot added lgtm and removed lgtm labels Mar 27, 2019
@hongye-sun
Copy link
Contributor

/lgtm

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

4 similar comments
@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@hongye-sun
Copy link
Contributor

/test kubeflow-pipeline-e2e-test

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@hongye-sun
Copy link
Contributor

/retest

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@gaoning777
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1d617b5 into kubeflow:master Mar 28, 2019
@gaoning777 gaoning777 deleted the add-loop-sample branch March 28, 2019 17:58
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
…low#1016)

* add new logic to cover new tekton runafter condition

* fix loop condition error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants