chore(sdk): Remove the (<type>)from docstring args.
#10159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remote the ` (<type>)` from the docstring args, which are redundant since there are type annotations.
connor-mccarthy
requested changes
Oct 26, 2023
| function (str, optional): The function name to compile. | ||
| read (bool): Whether the pipeline/component supports deserialization from YAML (IR, except for V1 component YAML back compatability tests). | ||
| write (bool): Whether the pipeline/component supports compilation from a Python file. | ||
| name : '{test_group_name}-{test_case_name}'. Useful for print statements/debugging. |
There was a problem hiding this comment.
Can we trim the leading space before the colon : -> :? (ref: Google Python Style Guide)
connor-mccarthy
approved these changes
Oct 26, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: connor-mccarthy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
connor-mccarthy
changed the title
(<type>)from docstring args. (<type>)from docstring args.
stijntratsaertit
pushed a commit
to stijntratsaertit/kfp
that referenced
this pull request
Feb 16, 2024
* chore(sdk): Remove the ` (<type>)`from docstring args. Remote the ` (<type>)` from the docstring args, which are redundant since there are type annotations. * Trim the unnecessary leading space.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
(<type>)from the docstring args, which are redundant since there are type annotations.Checklist: