Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hard-coded model export dir name #1015

Merged
merged 2 commits into from
Mar 21, 2019

Conversation

hongye-sun
Copy link
Contributor

@hongye-sun hongye-sun commented Mar 21, 2019

The change includes:

  • Expose optional model payload in the interface
  • Fix exporter folder searching logic to not depend on hard-coded export dir name.

The new searching logic assumes that user will provide the model_uri is either the direct parent folder of a model file or the base export dir, which contains a list of timestamped sub-directories.


This change is Reviewable

@hongye-sun hongye-sun changed the title FIx hard-coded model export dir name Fix hard-coded model export dir name Mar 21, 2019
@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 21, 2019

direct parent folder of a model file

Is a model a single file? Can model_uri also point to that file then?

/lgtm

@k8s-ci-robot k8s-ci-robot assigned Ark-kun and unassigned Ark-kun Mar 21, 2019
@hongye-sun
Copy link
Contributor Author

Direct link to model file doesn't work today. Only parent directory is supported.

@hongye-sun
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5ccbbb9 into kubeflow:master Mar 21, 2019
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants