Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Docker-in-Docker in DSL (See https://github.com/argoproj/argo/tree/master/examples#docker-in-docker-using-sidecars) #759

Closed
ukclivecox opened this issue Jan 31, 2019 · 9 comments
Assignees
Labels
area/sdk/dsl help wanted The community is welcome to contribute. kind/feature priority/p1

Comments

@ukclivecox
Copy link
Contributor

We would like to have steps in a pipeline that allow image builders. This might require docker-in-docker.
How can this be easily facilitated?

@jlewi
Copy link
Contributor

jlewi commented Feb 1, 2019

I think one option would be to have your pipeline step run a separate K8s job. Then you could set whatever options (e.g. DockerInDocker, Security context are needed).

@paveldournov
Copy link
Contributor

@cliveseldon - Please take a look at the KFP SDK, and the methods that allow building containers from Python functions. The SDK is creating a K8S job for building containers images, you can either use the SDK within a pipeline step or use the same technique for creating an image. Please let me know if that works.

@vicaire
Copy link
Contributor

vicaire commented Feb 13, 2019

@cliveseldon, Argo supports building containers inside containers.

See https://github.com/argoproj/argo/tree/master/examples#docker-in-docker-using-sidecars

Would making this functionality available from the DSL work for you?

@ukclivecox
Copy link
Contributor Author

Sorry, missed this. Yes that would be very useful if there was easy access to docker-in-docker.

@vicaire vicaire changed the title Support Pipeline Steps for Image Builders Add Support for Docker-in-Docker in DSL (See https://github.com/argoproj/argo/tree/master/examples#docker-in-docker-using-sidecars) Mar 4, 2019
@vicaire
Copy link
Contributor

vicaire commented Mar 4, 2019

/cc @hongye-sun (Adding Hongye who may have some input on this).

@cliveseldon, would you be interested in contributing so that it is easy to specify the following in the DSL?

https://github.com/argoproj/argo/tree/master/examples#docker-in-docker-using-sidecars

@ukclivecox
Copy link
Contributor Author

@vicaire Happy to help. Just a bit new to the code base so not sure where to start.

@hongye-sun
Copy link
Contributor

@cliveseldon, the docker in docker support depends on sidecar feature, which is currently working in the PR (#879). Once the PR is in, you should be able to build similar pipeline as argo example does.

@gaoning777
Copy link
Contributor

This #879 is merged. Feel free to add the docker-in-docker feature.

@gaoning777 gaoning777 added the help wanted The community is welcome to contribute. label Jun 26, 2019
@hongye-sun
Copy link
Contributor

I don't think there is more work need to be done to support dind other than the sidecar support. Closing this bug.

Linchin pushed a commit to Linchin/pipelines that referenced this issue Apr 11, 2023
* update set values tests

* use variable name consistency
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this issue Mar 11, 2024
for testing, no persistent storage is needed.
Use `emptyDir:{}` for minio and mysql

Signed-off-by: Yihong Wang <yh.wang@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sdk/dsl help wanted The community is welcome to contribute. kind/feature priority/p1
Projects
None yet
Development

No branches or pull requests

6 participants