Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScheduledWorkflow CRD: CLI #7

Closed
ynqa opened this issue Jun 5, 2018 · 9 comments
Closed

ScheduledWorkflow CRD: CLI #7

ynqa opened this issue Jun 5, 2018 · 9 comments

Comments

@ynqa
Copy link
Contributor

ynqa commented Jun 5, 2018

Will it prepare the scheduledworkflows' CLIs in this repository to manage controller like argo? Or adding subcommands to argo.

@vicaire
Copy link
Contributor

vicaire commented Jun 5, 2018

It will be done in this repo. Thanks!

@ynqa
Copy link
Contributor Author

ynqa commented Jun 6, 2018

@vicaire Already done to make CLI? If it has not started yet, I'll make it!

@vicaire
Copy link
Contributor

vicaire commented Jun 6, 2018

Sure, could you make a proposal of how it will look like?

It would be nice if it could take as a parameter a file with an Argo workflow, and automatically generate the yaml for the ScheduledWorkflow.

@ynqa
Copy link
Contributor Author

ynqa commented Jun 6, 2018

@vicaire First, I'll make a command for installation of controller and CRD like argo install. Then, scheduledworkflow controller is deployed as Deployment to kubernetes.

@vicaire
Copy link
Contributor

vicaire commented Jun 6, 2018

That looks great!

@jlewi
Copy link
Contributor

jlewi commented Jun 8, 2018

Why do we need a CLI to install the CRD? Why can't it just be installed as ksonnet package like all the other components in the registry?

Using a CLI to install the controllers goes against the idea in K8s of managing infrastructure decoratively using config.

I also don't think it would scale very well; e.g. having individual CLI's for every CRD in Kubeflow and forcing the user to install each one would be unwieldy.

@ynqa
Copy link
Contributor Author

ynqa commented Jun 8, 2018

@jlewi First, I think CLI to manage scheduledworkflows should be prepared. For example, for dealing with the case to continue execution of the Argo workflow where it left off (or by indicating arbitrary position). I think it's troublesome to handle this by kubectl and the manifests only.

And also I don't think it's strange to install the components (CRD/controller) into k8s using this CLI owing to consistency of operations.

But I agreed your opinions too. So I'll commit except for CLIs (I think there is no rush to prepare CLI itself) in #12 PR.

@vicaire
Copy link
Contributor

vicaire commented Jun 9, 2018

For installation of the CRD, we indeed need to conform to the Kubeflow standard of using a ksonnet package.

Thanks for the reminder @jlewi.

@ynqa
Copy link
Contributor Author

ynqa commented Jun 9, 2018

I got it. Thanks.

@ynqa ynqa closed this as completed Aug 12, 2018
Linchin pushed a commit to Linchin/pipelines that referenced this issue Apr 11, 2023
…les. (kubeflow#7)

Revert "Merge pull request #2 from jlewi/py"

This reverts commit 9273125, reversing
changes made to b018ac6.
HumairAK referenced this issue in HumairAK/data-science-pipelines Jan 22, 2024
UPSTREAM: <carry>: add actions from dsp tekton repo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants