Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run status tooltip should include creation time #61

Closed
Ark-kun opened this issue Nov 5, 2018 · 8 comments
Closed

Run status tooltip should include creation time #61

Ark-kun opened this issue Nov 5, 2018 · 8 comments

Comments

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 5, 2018

-- EDIT
"Last 5 runs" - is the last one (the rightmost) the real last run?

@rileyjbauer
Copy link
Contributor

The leftmost icon corresponds to the latest run

@yebrahim
Copy link
Contributor

yebrahim commented Nov 6, 2018

I'm afraid we just aren't doing a good job surfacing that design decision.
@ajayalfred for thoughts.

@ajayalfred
Copy link
Contributor

The current tooltip implementation is missing timestamps. Adding timestamps will make it very clear what the latest run is. Please add as shown below.

screen shot 2018-11-06 at 9 40 51 am

@yebrahim yebrahim changed the title "Last 5 runs" - is the last one (the rightmost) the real last run? Run status tooltip should include creation time Dec 4, 2018
@yebrahim
Copy link
Contributor

yebrahim commented Dec 4, 2018

I think the tooltip should include creation time not completion time, multiple runs can (it's common) be running in parallel.

@ajayalfred
Copy link
Contributor

Can both be included?
Two attributes of a run is represented by the status icon - the run itself and it's status. Agree that creation time will be useful. Although a user may also want to know when the run finished/stopped/failed/etc.. Including both the timestamps will serve both these use cases.

@yebrahim
Copy link
Contributor

Don't you think that's too much detail for the tooltip though? You can always check the run details to see all that information.
A mock would be useful.

@ajayalfred
Copy link
Contributor

No it isn't be too much detail for a tooltip.
The tooltip must describe the status – if we want to include creation time then additional text has to be added to separate status description from run creation timestamp. See below.

image

Please note ellipsis at the end of first three status descriptions.

@rileyjbauer
Copy link
Contributor

This is fixed as of #671, although I need to tweak the format of the tooltips a little to fully mirror Ajay's design

Linchin pushed a commit to Linchin/pipelines that referenced this issue Apr 11, 2023
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
* pausing

* freezing before fixing folders

* got end to end interfaces in place

* pausing for WIP review

* Added sample xgboost yaml

* changes

* Separated XGB from KFServer

* refactored

* Updated PR comments and added server threading
HumairAK referenced this issue in red-hat-data-services/data-science-pipelines Mar 11, 2024
feat(backend): Adding a cron job for MariaDB backup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants