Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2compat] UI features for cached tasks (size/S) #5977

Closed
5 tasks done
Tracked by #5667
Bobgy opened this issue Jul 6, 2021 · 2 comments · Fixed by #6556
Closed
5 tasks done
Tracked by #5667

[v2compat] UI features for cached tasks (size/S) #5977

Bobgy opened this issue Jul 6, 2021 · 2 comments · Fixed by #6556

Comments

@Bobgy
Copy link
Contributor

Bobgy commented Jul 6, 2021

For cached tasks, the following are helpful on UI:

  • * cached status icon
  • * a link to cached execution
  • * (p1) a link to original execution this cache is taken from
  • * (p2) the original execution should have a link to the original run (deleting the original run will invalidate cache)
  • * (p2) the run details page should ideally support using url hash to select a node, so that we can generate a URL that directly selects a node in a run details page
@Bobgy Bobgy changed the title UI should show cached status icon for cached tasks (size/S) [v2compat] UI should show cached status icon for cached tasks (size/S) Jul 6, 2021
@Bobgy Bobgy changed the title [v2compat] UI should show cached status icon for cached tasks (size/S) [v2compat] UI features for cached tasks (size/S) Jul 6, 2021
@capri-xiyue
Copy link
Contributor

capri-xiyue commented Jul 20, 2021

Discussed with @zijianjoy offline,
Currently with v2 compatible mode,

  • cached status icon
  • a link to cached execution
    The above tasks can be achieved now.

For the following tasks, currently we can't fetch original execution with current logic in launcher.
We may need to store the original mlmd execution id in the cache mlmd execution first(Maybe via a custom property called cached_execution_id). I'm not sure whether we need to support these in v2 compatible mode. I think these features will be useful to users once we support cache staleness.
For my perspective, we can defer these two tasks until we support cache staless. @Bobgy What do you think of it?

  • (p1) a link to original execution this cache is taken from
  • (p2) the original execution should have a link to the original run (deleting the original run will invalidate cache)

@zijianjoy
Copy link
Collaborator

I think it will be great to describe the user scenario for referencing original execution from cached execution. Based on the discussion, looks like there is no cache management exposed to user in v2 compatible mode, so the linking from cached execution to original execution is informational at this point, and help user to understand more about the caching mechanism (debugging).

The solution with custom property cached_execution_id should work, but I suggest to get confirmation from the team about defining this field, so we can avoid changing/removing this property in the future, where FE needs to support property field compatibility across versions.

google-oss-robot pushed a commit that referenced this issue Jul 23, 2021
* feat(frontend): Show cache icon for v2 compatible

* log removed
google-oss-robot pushed a commit that referenced this issue Aug 5, 2021
…n detail page. Partial #5977 (#6218)

* feat(frontend): Select node using execution ID via router param in run detail page.

* revert test snapshot

* fix router test

* fix type casting

* fix test
google-oss-robot pushed a commit that referenced this issue Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants