Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the versioning of artifacts and/or pipelines. #467

Closed
yebrahim opened this issue Dec 4, 2018 · 8 comments
Closed

Support the versioning of artifacts and/or pipelines. #467

yebrahim opened this issue Dec 4, 2018 · 8 comments

Comments

@yebrahim
Copy link
Contributor

yebrahim commented Dec 4, 2018

This is a high level work item to track work needed to support pipeline versioning, including what links versions together, identifying a version when creating runs, comparing versions.. etc.

@vicaire
Copy link
Contributor

vicaire commented Mar 26, 2019

Riley or Pavel, do you are more details on this one? I am not exactly sure of what the scope would be.

Is it about versions of the pipeline system?

Or is it about versioned pipelines?

Should it be about versioned pipelines in general instead of just the front-end?

@rileyjbauer
Copy link
Contributor

This is about versioned pipelines, not the system itself.

Yes, this should not be frontend specific.

@vicaire
Copy link
Contributor

vicaire commented Mar 27, 2019

Thanks @rileyjbauer. I am going to repurpose this issue to track the versioning of artifacts in general (not just in the UI).

This seems closely related to the ongoing work on a Metadata store that keeps track of which artifacts were generated by which pipelines.

@vicaire vicaire changed the title Support pipeline versioning on the frontend Support the versioning of artifacts. Mar 27, 2019
@vicaire vicaire changed the title Support the versioning of artifacts. Support the versioning of artifacts and/or pipelines. Mar 28, 2019
@vicaire vicaire assigned neuromage and unassigned rileyjbauer Mar 28, 2019
@JohnPaton
Copy link
Contributor

I'm just checking out Pipelines at the moment but it's looking great, thanks for your work on it!

With the current UI, it doesn't seem there is any way to edit or upload a new version of a pipeline. Considering this, how do you test your pipelines?

As an example, I had a typo in the URI for a container in my pipeline, and fixing that one typo required deleting and re-uploading the whole thing. Is that the current workflow, and is it the plan to add some flexibility here?

"Upload a new version" or "edit the config in the browser" would be some nice features to have :)

@vicaire
Copy link
Contributor

vicaire commented Apr 23, 2019

@JohnPaton, yes, at the moment, modifying a pipeline requires uploading/executing a new pipeline.

@jomach
Copy link

jomach commented May 9, 2019

What about implementing a git clone from a url additionally to import from file ?

@k8s-ci-robot
Copy link
Contributor

Linchin pushed a commit to Linchin/pipelines that referenced this issue Apr 11, 2023
…low repository, I ran into problems with the import failing because the module kubeflow.kubeflow could not be found (kubeflow#466)

The issue is tracked kubeflow#467

Essentially dynamically adding the kubeflow/kubeflow/py (i.e. from inside python) didn't work

Could be an issue with namespace packaging
I spent hours trying to make dynamically importing the modules work but I couldn't figure it out

Setting python path before invoking python appears to work. So as a workaround we have run_e2e_workflow.py shell out to e2e_tool which writes the workflow to a file. run_e2e_workflow.py then loads it from the file.

Create a K8s job to run run_e2e_workflow.py to simulate what happens
under prow

Related to kubeflow/kubeflow#3035 migrate e2e tests off ksonnet
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
* Request Logging in Control Plane

* change executor to logger in release scripts

* change executor into logger

* initial inference logger commit

* initial Q version of inference logger

* Add initial cloudevents code

* add cloudevents and opencensus vendor additions

* update cloudevents and create example

* add log_type and sample

* Add logging to transformers and explainers

* Add validation tests

* Allow default log url to be knative default broker

* Bring inference logger annotations into single method

* add model_url and update examples

* refactor to logger

* Update logger Dockerfile

* Fix compile errors after rebase

* Logger files, and test

* Remove sample and add modelId

* Updates from review

* Updates from review

* Updates from testing

* Update from review comments

* update workflow to replace executor with logger

* regenerate tf2openapi

* Updates from review

* review updates

* Updates from review
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this issue Mar 11, 2024
 kubeflow#467] (kubeflow#468)

* fix: update the api to latest kubeflow pipelines for katib sample[ Fixes kubeflow#467]

* Interesting set of changes seemed to fix that error.

* added return statements.

* Looks like a bug in compiler forces us to do this.

* move contrib/katib to sample/katib.

* review feedback

* Remove mpi operator based samples as it does not come installed by default.

* resolve k8s client version conflict by rearranging the deps in notebook.

* Contains all the outputs of a successfully executed notebook.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants