Using custom DNS with Python SDK (kfp)

[kelvins]

The _is_iap_host method is being called in the Client initialization, but it is using a regex based on the default DNS (e.g. kubeflow.endpoints.my-project.cloud.goog/pipeline):

pipelines/sdk/python/kfp/_client.py

Lines 156 to 161 in 0577fe1

	def _is_iap_host(self, host, client_id):
	if host and client_id:
	if re.match(r'\S+.endpoints.\S+.cloud.goog/{0,1}$', host):
	warnings.warn('Suffix /pipeline is not ignorable for IAP host.')
	return re.match(r'\S+.endpoints.\S+.cloud.goog/pipeline', host)
	return False

In this case, how can we use a custom DNS?

[Ark-kun]

Maybe we should add the optional use_iap parameter, so that the user can specify this explicitly.

[kelvins]

Sounds good, but as far as I know client_id is only used for IAP, so passing client_id and use_iap seems to be a little redundant.

Another option would be to change the regular expression to not be so restricted, for example:

def _is_iap_host(self, host, client_id):
    if host and client_id:
        if re.match(r'\S+/{0,1}$', host):
            warnings.warn('Suffix /pipeline is not ignorable for IAP host.')
        return re.match(r'\S+/pipeline', host)
    return False

[Ark-kun]

@numerology @hongye-sun WDYT?

[Bobgy]

/close
Already fixed by #3003

[k8s-ci-robot]

@Bobgy: Closing this issue.

In response to this:

/close
Already fixed by #3003

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.