Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a custom kube config location in K8sJobHelper #2682

Closed
pahask8 opened this issue Nov 29, 2019 · 3 comments · Fixed by #2683
Closed

Support a custom kube config location in K8sJobHelper #2682

pahask8 opened this issue Nov 29, 2019 · 3 comments · Fixed by #2683

Comments

@pahask8
Copy link
Contributor

pahask8 commented Nov 29, 2019

What happened:

Currently there is no way to pass a custom Kube config file location. Based on

, there are 2 ways of authorizing in k8s:

  1. In cluster config
    config.load_incluster_config()
  2. Default k8s config location (~/.kube/config):
    config.load_kube_config()

What did you expect to happen:
My use case: I use Jenkins in k8s to build a kf docker images which leaves in a separate k8s cluster. That means, that I can build a docker images using KF only in the same cluster because it will try to use in cluster config. I expect to pass a custom kube config file location and use it.

What steps did you take:
My use case: I use Jenkins in k8s to build a kf docker images which leaves in a separate k8s cluster. That means, that I can build a docker images using KF only in the same cluster because it will try to use in cluster config. I expect to pass a custom kube config file location and use it.

Anything else you would like to add:
Wil create a pull request.

@pahask8
Copy link
Contributor Author

pahask8 commented Nov 29, 2019

Pull request #2683

@gaoning777
Copy link
Contributor

/unassign @gaoning777
/assign @Ark-kun
Hi, Alexey, could you help update the SDK?

@Ark-kun
Copy link
Contributor

Ark-kun commented Jan 16, 2020

Fixed by #2682

@Ark-kun Ark-kun closed this as completed Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants