Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UI to display step duration #2159

Closed
hlu09 opened this issue Sep 18, 2019 · 11 comments
Closed

Update UI to display step duration #2159

hlu09 opened this issue Sep 18, 2019 · 11 comments
Assignees
Labels
area/frontend help wanted The community is welcome to contribute. kind/feature lifecycle/frozen priority/p1 starter status/triaged Whether the issue has been explicitly triaged

Comments

@hlu09
Copy link
Contributor

hlu09 commented Sep 18, 2019

It is nice to know how long individual step took.

@rmgogogo
Copy link
Contributor

@hlu09 Thanks for feedback.
Would you help provide more info so that we can handle it better?

Any reason why you prefer display the step duration? For debugging purpose?

@hlu09
Copy link
Contributor Author

hlu09 commented Nov 18, 2019

Current UI has "start" and "end" time of each step. It'd be nice to show a duration too to save users from doing mental math to figure out how long it ran.

@Bobgy
Copy link
Contributor

Bobgy commented Jan 22, 2020

I think this looks like a small change, and it is useful in many cases (understanding pipeline performance e.t.c).

@Bobgy Bobgy added the starter label Mar 6, 2020
@elikatsis
Copy link
Member

Hi there,

Does the current UI show the start & end time of each step?
If yes (as mentioned in a previous comment), I can't find it 😅 could you guide me a bit where to look for it?
If not, and since this information is persisted in the workflow's status which is already parsed by the UI (Workflow.Status.Nodes), is there any design for the desired UX and an estimation for its implementation?

Thanks!

@Bobgy
Copy link
Contributor

Bobgy commented Mar 12, 2020

Hi @elikatsis, I checked and looks like KFP UI doesn't show step level start and end time, it only shows workflow start and end time.
But the data is available anyway in

(Object as any).values(workflowNodes).forEach((node: NodeStatus) => {
, the nodeStatus type has startedAt and finishedAt fields recording this. (WorkflowParser is used to parse data used to show on run details page.)

These data come from argo workflow status fields, there are both step level and workflow level start and finish time, so we can calculate and show durations.

There isn't any existing design to show this, welcome proposing whatever design that feels right to you.
Contributions welcomed!

@Bobgy Bobgy added the help wanted The community is welcome to contribute. label Mar 12, 2020
@Bobgy Bobgy assigned Bobgy and unassigned jingzhang36 Mar 12, 2020
@stale
Copy link

stale bot commented Jun 24, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Jun 24, 2020
@Bobgy
Copy link
Contributor

Bobgy commented Jun 24, 2020

we plan to do this

@stale stale bot removed the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Jun 24, 2020
@stale
Copy link

stale bot commented Sep 22, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Sep 22, 2020
@Bobgy
Copy link
Contributor

Bobgy commented Sep 29, 2020

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen and removed lifecycle/stale The issue / pull request is stale, any activities remove this label. labels Sep 29, 2020
@zijianjoy
Copy link
Collaborator

/assign @zijianjoy

@zijianjoy
Copy link
Collaborator

We now have a tab to show all the task details, including duration: #5023

magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
Signed-off-by: Ryan McCormick <rmccormick@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend help wanted The community is welcome to contribute. kind/feature lifecycle/frozen priority/p1 starter status/triaged Whether the issue has been explicitly triaged
Projects
None yet
Development

No branches or pull requests

7 participants