-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embeddable run view page #182
Comments
The run details page is one of the more complicated parts of the frontend. What's the use case for this? |
The scenario is embedding the run view in the Notebook. |
But why? Assuming you're talking about a Jupyter notebook hosted from a Kubeflow cluster, why not just click a link to see the run in the Pipelines UI? Is the goal to save this click? Or is the above assumption incorrect? Are you talking about a completely standalone notebook, with visualizations packaged into it? |
Yes. This is about saving a click each time you want to check the run. This is even more important when the user runs JupyterLab as a separate application and not as a browser tab. |
Is it hard to add support for query parameter like |
Can you elaborate on the JupyterLab-as-separate-application part? Is it still backed by the KF cluster kernel manager? This isn't about changing the view or removing the chrome, it's about hosting our entire UI webapp in the notebook's cell output iframe, and most importantly finding a way around CORS. If the only motive here is saving a single click, I don't see why we should pursue this. |
I'll close this as I don't see a good reason for it, nor do I see a good way of doing it. |
I also wanted clarification on this. What would be different in JupyterLab? Does jupyter use an iframe to show KFP UI page? Did you try so? It should already show the UI, just with the navigation. If you already verified that works, this feature isn't very hard. Although I kind of doubt how many people actually wants it. Does the efforts worth saving a click? |
As far as I remember, I've verified that Jupyter can show iframes with arbitrary pages. That IFrame has limited height by default, so the top navigation obscures most of it.
The idea is to be able to stay in the development environment (Jupyter) while monitoring the work progress. I think this will look pretty cool can unique for demos. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I can follow up on a demo with this, shouldn't be too hard |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
/frozen |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
/cc @Jamxl @StefanoFioravanzo |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it. |
* add Dockerfile for alibiexplainer * fix missing quote on entrypoint args * use python:3.7 base image for alibiexplainer
I'd like to insert the run view page into a notebook when I submit the run.
For this I'd like to have a minimal page without left or top navigation, with only the run view and the refresh button.
The text was updated successfully, but these errors were encountered: