Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

600 sec timeline for docker build is too short #1549

Closed
SinaChavoshi opened this issue Jun 24, 2019 · 1 comment
Closed

600 sec timeline for docker build is too short #1549

SinaChavoshi opened this issue Jun 24, 2019 · 1 comment
Assignees
@gaoning777
Labels
area/sdk/components kind/feature

Comments

@SinaChavoshi
Copy link
Contributor

Docker build step is hardcoded to time out at 600s (reference:

pipelines/sdk/python/kfp/compiler/_component_builder.py

Line 545 in 02313e4

timeout (int): the timeout for the image build(in secs), default is 600 seconds
)

This timed out for a common build environment.
@gaoning777 gaoning777 mentioned this issue Jun 24, 2019
Merged
@gaoning777 gaoning777 self-assigned this Jun 24, 2019
@SinaChavoshi
Copy link
Contributor Author

additionally it is not obvious to the user what happened when they hit this time out as the process successfully completes (looking at last line ). It may make sense to add the timeout setting as an optional field.

magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
@abchoo
Prevents /mnt/models/<model name> from being converted into a file (k…
57b548d 
…ubeflow#1549)

* prevents file directory from becoming a file

* updated gcs test file to be within the model directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gaoning777 gaoning777

Labels
area/sdk/components kind/feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gaoning777 @SinaChavoshi