Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Artifact preview not working with default minio, and no experiment namespace (standalone install) #11058

Closed
HumairAK opened this issue Jul 31, 2024 · 4 comments · Fixed by #11059
Labels

Comments

@HumairAK
Copy link
Collaborator

Environment

KFP main branch on Kubernetes

Steps to reproduce

Deploy main branch using default minio, create a pipeline run that generates artifacts in the default minio

You will encounter something like:

image

This happens because in standalone installations, experiments don't have a default namespace, so the UI server does not know where to fetch the secrets for a given run artifact's object store. We should make the UI aware of the namespace it's installed in, and use this namespace as the default if no experiment namespace is detected.

Resolving this will not fix previews however, because then we will encounter an INVALID_URL response and this is because of the way we URL parse the object store endpoint: https://github.com/kubeflow/pipelines/blob/master/frontend/server/minio-helper.ts#L151 which expects endpoints to be in the WHATWG standard, however the endpoint from backend by default minio setup is <ip>:<port>, which does not include the protocol, thus making it invalid. We should update this to properly adhere to the standard. But we can add a backwards compatibility support for older configurations to continue to handle this.

Expected result

Artifacts should correctly preview with default minio deployment

Labels


Impacted by this bug? Give it a 👍.

@HumairAK
Copy link
Collaborator Author

HumairAK commented Jul 31, 2024

/label priority/p0

this is IMO 100% future release blocking, as this puts artifact previews in a non working state for standalone deployments

Copy link

@HumairAK: The label(s) `/label priority/p0

cannot be applied. These labels are supported:tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash. Is this label configured under labels -> additional_labelsorlabels -> restricted_labelsinplugin.yaml`?

In response to this:

/label priority/p0

this is IMO 100% future release blocking, as this puts artifact previews in a non working state for standalone deployments

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@HumairAK
Copy link
Collaborator Author

/label priority/p0

Copy link

@HumairAK: The label(s) /label priority/p0 cannot be applied. These labels are supported: tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label priority/p0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant