Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Filter pipeline text box shows error when typing anything in it #10241

Closed
czchen opened this issue Nov 16, 2023 · 14 comments
Closed

Comments

@czchen
Copy link

czchen commented Nov 16, 2023

Environment

  • How did you deploy Kubeflow Pipelines (KFP)? kustomization
  • KFP version: 2.0.3

Steps to reproduce

  • Select Runs on left sidebar.
  • Select + Create run on top right sidebar.
  • Select Choose in Pipeline input box.
  • Type a in Filter pipelines input text.
  • An Error retrieving resources is poped up, with the following error message
List request failed with:
{"error":"Failed to list pipelines due invalid list options: pageToken: , pageSize: 10, sortBy: created_at desc, filter: %7B%22predicates%22%3A%5B%7B%22key%22%3A%22name%22%2C%22op%22%3A%22IS_SUBSTRING%22%2C%22string_value%22%3A%22a%22%7D%5D%7D: Invalid input error: failed to parse valid filter from \"%7B%22predicates%22%3A%5B%7B%22key%22%3A%22name%22%2C%22op%22%3A%22IS_SUBSTRING%22%2C%22string_value%22%3A%22a%22%7D%5D%7D\": unknown field \"op\" in kubeflow.pipelines.backend.api.v2beta1.Predicate","code":3,"message":"Failed to list pipelines due invalid list options: pageToken: , pageSize: 10, sortBy: created_at desc, filter: %7B%22predicates%22%3A%5B%7B%22key%22%3A%22name%22%2C%22op%22%3A%22IS_SUBSTRING%22%2C%22string_value%22%3A%22a%22%7D%5D%7D: Invalid input error: failed to parse valid filter from \"%7B%22predicates%22%3A%5B%7B%22key%22%3A%22name%22%2C%22op%22%3A%22IS_SUBSTRING%22%2C%22string_value%22%3A%22a%22%7D%5D%7D\": unknown field \"op\" in kubeflow.pipelines.backend.api.v2beta1.Predicate","details":[{"@type":"type.googleapis.com/google.rpc.Status","code":3,"message":"failed to parse valid filter from \"%7B%22predicates%22%3A%5B%7B%22key%22%3A%22name%22%2C%22op%22%3A%22IS_SUBSTRING%22%2C%22string_value%22%3A%22a%22%7D%5D%7D\": unknown field \"op\" in kubeflow.pipelines.backend.api.v2beta1.Predicate"}]}

Expected result

There shall be no error message when typing in Filter pipelines input box.

Materials and Reference


Impacted by this bug? Give it a 👍.

@lethee
Copy link

lethee commented Jan 4, 2024

I have same issue.

Predicate:

{
    "predicates": [
        {
            "key": "name",
            "op": "IS_SUBSTRING",
            "string_value": "d"
        },
        {
            "key": "storage_state",
            "operation": "NOT_EQUALS",
            "string_value": "ARCHIVED"
        }
    ]
}

My env:

{
    "buildDate": "Fri Oct 27 04:09:58 UTC 2023",
    "frontendCommitHash": "58ce09e07d031964905020c749e77bf0f37e83d4",
    "frontendTagName": "2.0.3",
    "apiServerReady": true,
    "apiServerCommitHash": "58ce09e07d031964905020c749e77bf0f37e83d4",
    "apiServerTagName": "2.0.3",
    "apiServerMultiUser": true,
    "multi_user": true
}
Screenshot 2024-01-04 at 11 31 26 AM

I think problem is on https://github.com/kubeflow/pipelines/blob/master/frontend/src/components/CustomTable.tsx#L545

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Mar 15, 2024
Copy link

github-actions bot commented Apr 5, 2024

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@github-actions github-actions bot closed this as completed Apr 5, 2024
@tom-pavz
Copy link

tom-pavz commented Jun 7, 2024

We are still seeing this exact bug in KFP backend 2.1.0

@HumairAK
Copy link
Collaborator

HumairAK commented Jun 7, 2024

/re-open

@HumairAK
Copy link
Collaborator

HumairAK commented Jun 7, 2024

/reopen

Copy link

@HumairAK: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@google-oss-prow google-oss-prow bot reopened this Jun 7, 2024
@github-actions github-actions bot removed the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Jun 8, 2024
@thesuperzapper
Copy link
Member

@droctothorpe given your work on #10797, I wonder if you have also seen this issue?

It seems like the first time you try and create a new run by:

  1. Going to the "Runs" page
  2. Clicking "Create Run"
  3. Clicking "Choose" pipeline
  4. Finding a pipeline and clicking "Use this Pipeline"

You will get a crazy slow response, or sometimes you will get an error like what this issue raises.

@droctothorpe
Copy link
Contributor

We've noticed this as well! Haven't had a chance to debug it yet though.

@thesuperzapper
Copy link
Member

@droctothorpe The issue I am talking about in #10241 (comment) seems to be different from the one raised by @czchen in this issue, sorry. I have raised a separate issue for that: #10897

The issue is raised by @czchen is still very important because it's actually a broken feature (filtering literally does not work in V2).

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Aug 12, 2024
@HumairAK
Copy link
Collaborator

/remove-lifecycle stale

@google-oss-prow google-oss-prow bot removed the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Aug 12, 2024
@ElayAharoni
Copy link
Contributor

/assign

ElayAharoni pushed a commit to ElayAharoni/pipelines that referenced this issue Aug 13, 2024
…low#10241

Signed-off-by: Elay Aharoni (EXT-Nokia) <elay.aharoni.ext@nokia.com>
ElayAharoni pushed a commit to ElayAharoni/pipelines that referenced this issue Aug 13, 2024
…low#10241

Signed-off-by: Elay Aharoni (EXT-Nokia) <elay.aharoni.ext@nokia.com>
ElayAharoni pushed a commit to ElayAharoni/pipelines that referenced this issue Aug 13, 2024
@boarder7395
Copy link
Contributor

boarder7395 commented Aug 15, 2024

Tested this in 2.2.0 and search is still broken. I took a look at #10358 and while it fixes the create run page, it breaks the clone from run page.

Create Run Page Error on 2.2.0:
Screenshot 2024-08-15 at 2 39 08 PM

Clone Run Page Error with fix #10358 and #11096
Screenshot 2024-08-15 at 3 11 05 PM

KevinGrantLee pushed a commit that referenced this issue Sep 17, 2024
… anything in it. Fixes #10241 (#11096)

* Filter pipeline text box shows error when typing anything in it #10241

Signed-off-by: Elay Aharoni (EXT-Nokia) <elay.aharoni.ext@nokia.com>

* Filter pipeline text box shows error when typing anything in it #10241

Signed-off-by: Elay Aharoni (EXT-Nokia) <elay.aharoni.ext@nokia.com>

---------

Signed-off-by: Elay Aharoni (EXT-Nokia) <elay.aharoni.ext@nokia.com>
Co-authored-by: Elay Aharoni (EXT-Nokia) <elay.aharoni.ext@nokia.com>
Signed-off-by: KevinGrantLee <kglee@google.com>
sefgsefg pushed a commit to sefgsefg/pipelines that referenced this issue Sep 18, 2024
… anything in it. Fixes kubeflow#10241 (kubeflow#11096)

* Filter pipeline text box shows error when typing anything in it kubeflow#10241

Signed-off-by: Elay Aharoni (EXT-Nokia) <elay.aharoni.ext@nokia.com>

* Filter pipeline text box shows error when typing anything in it kubeflow#10241

Signed-off-by: Elay Aharoni (EXT-Nokia) <elay.aharoni.ext@nokia.com>

---------

Signed-off-by: Elay Aharoni (EXT-Nokia) <elay.aharoni.ext@nokia.com>
Co-authored-by: Elay Aharoni (EXT-Nokia) <elay.aharoni.ext@nokia.com>
Signed-off-by: sefgsefg <sefgsefg@gmail.com>
R3hankhan123 pushed a commit to R3hankhan123/pipelines that referenced this issue Sep 20, 2024
… anything in it. Fixes kubeflow#10241 (kubeflow#11096)

* Filter pipeline text box shows error when typing anything in it kubeflow#10241

Signed-off-by: Elay Aharoni (EXT-Nokia) <elay.aharoni.ext@nokia.com>

* Filter pipeline text box shows error when typing anything in it kubeflow#10241

Signed-off-by: Elay Aharoni (EXT-Nokia) <elay.aharoni.ext@nokia.com>

---------

Signed-off-by: Elay Aharoni (EXT-Nokia) <elay.aharoni.ext@nokia.com>
Co-authored-by: Elay Aharoni (EXT-Nokia) <elay.aharoni.ext@nokia.com>
sefgsefg pushed a commit to sefgsefg/pipelines that referenced this issue Sep 20, 2024
… anything in it. Fixes kubeflow#10241 (kubeflow#11096)

* Filter pipeline text box shows error when typing anything in it kubeflow#10241

Signed-off-by: Elay Aharoni (EXT-Nokia) <elay.aharoni.ext@nokia.com>

* Filter pipeline text box shows error when typing anything in it kubeflow#10241

Signed-off-by: Elay Aharoni (EXT-Nokia) <elay.aharoni.ext@nokia.com>

---------

Signed-off-by: Elay Aharoni (EXT-Nokia) <elay.aharoni.ext@nokia.com>
Co-authored-by: Elay Aharoni (EXT-Nokia) <elay.aharoni.ext@nokia.com>
google-oss-prow bot pushed a commit that referenced this issue Sep 20, 2024
…etters (#11097)

* temp title: change title

Signed-off-by: KevinGrantLee <kglee@google.com>

* add release notes

Signed-off-by: KevinGrantLee <kglee@google.com>

* formatting

Signed-off-by: KevinGrantLee <kglee@google.com>

* feat(backend): move comp logic to workflow params (#10979)

* feat(backend): move comp logic to workflow params

Signed-off-by: zazulam <m.zazula@gmail.com>
Co-authored-by: droctothorpe <mythicalsunlight@gmail.com>
Co-authored-by: andreafehrman <andrea.k.fehrman@vanderbilt.edu>
Co-authored-by: MonicaZhang1 <zhangmonica1@gmail.com>
Co-authored-by: kylekaminky <kyle.kaminky@gmail.com>
Co-authored-by: CarterFendley <carter.fendley@gmail.com>
Signed-off-by: zazulam <m.zazula@gmail.com>

* address pr comments

Signed-off-by: zazulam <m.zazula@gmail.com>

* Use function name instead of base name and address edge cases

Signed-off-by: droctothorpe <mythicalsunlight@gmail.com>
Co-authored-by: zazulam <m.zazula@gmail.com>

* Improve logic and update tests

Signed-off-by: droctothorpe <mythicalsunlight@gmail.com>
Co-authored-by: zazulam <m.zazula@gmail.com>

* POC hashing command and args

Signed-off-by: droctothorpe <mythicalsunlight@gmail.com>
Co-authored-by: zazulam <m.zazula@gmail.com>

* Add comments to clarify the logic

Signed-off-by: droctothorpe <mythicalsunlight@gmail.com>
Co-authored-by: zazulam <m.zazula@gmail.com>

* Hash entire PipelineContainerSpec

Signed-off-by: droctothorpe <mythicalsunlight@gmail.com>
Co-authored-by: zazulam <m.zazula@gmail.com>

---------

Signed-off-by: zazulam <m.zazula@gmail.com>
Signed-off-by: droctothorpe <mythicalsunlight@gmail.com>
Co-authored-by: droctothorpe <mythicalsunlight@gmail.com>
Co-authored-by: andreafehrman <andrea.k.fehrman@vanderbilt.edu>
Co-authored-by: MonicaZhang1 <zhangmonica1@gmail.com>
Co-authored-by: kylekaminky <kyle.kaminky@gmail.com>
Co-authored-by: CarterFendley <carter.fendley@gmail.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* feat(component): internal

Signed-off-by: Googler <nobody@google.com>
PiperOrigin-RevId: 660985413
Signed-off-by: KevinGrantLee <kglee@google.com>

* feat(components): internal

Signed-off-by: Googler <nobody@google.com>
PiperOrigin-RevId: 661332120
Signed-off-by: KevinGrantLee <kglee@google.com>

* fix(components): Fix to model batch explanation component for Structured Data pipelines

Signed-off-by: Googler <nobody@google.com>
PiperOrigin-RevId: 661475667
Signed-off-by: KevinGrantLee <kglee@google.com>

* feat(components): Support dynamic values for boot_disk_type, boot_disk_size in preview.custom_job.utils.create_custom_training_job_from_component

Signed-off-by: Googler <nobody@google.com>
PiperOrigin-RevId: 662242688
Signed-off-by: KevinGrantLee <kglee@google.com>

* chore: Upgrade Argo to v3.4.17 (#10978)

Signed-off-by: Giulio Frasca <gfrasca@redhat.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* test: Moved kubeflow-pipelines-manifests to GitHub Actions (#11066)

Signed-off-by: vmudadla <vmudadla@redhat.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* fix: re-enable exit hanler test. (#11100)

Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>
Co-authored-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* fix(frontend): retrieve archived logs from correct location (#11010)

* fix(frontend): retrieve archived logs from correct location

Signed-off-by: droctothorpe <mythicalsunlight@gmail.com>
Co-authored-by: andreafehrman <andrea.k.fehrman@vanderbilt.edu>
Co-authored-by: owmasch <owenmaschal0598@gmail.com>

* Add namespace tag handling and validation

Signed-off-by: droctothorpe <mythicalsunlight@gmail.com>
Co-authored-by: andreafehrman <andrea.k.fehrman@vanderbilt.edu>
Co-authored-by: owmasch <owenmaschal0598@gmail.com>

* Remove whitespace from keyFormat

Signed-off-by: droctothorpe <mythicalsunlight@gmail.com>
Co-authored-by: andreafehrman <andrea.k.fehrman@vanderbilt.edu>
Co-authored-by: owmasch <owenmaschal0598@gmail.com>

* Update frontend unit tests

Signed-off-by: droctothorpe <mythicalsunlight@gmail.com>

* Remove superfluous log statements

Signed-off-by: droctothorpe <mythicalsunlight@gmail.com>
Co-authored-by: quinnovator <jack@jq.codes>

* Add link to keyFormat in manifests

Signed-off-by: droctothorpe <mythicalsunlight@gmail.com>

* Fix workflow parsing for log artifact

Signed-off-by: droctothorpe <mythicalsunlight@gmail.com>
Co-authored-by: quinnovator <jack@jq.codes>

* Fix unit test

Signed-off-by: droctothorpe <mythicalsunlight@gmail.com>

---------

Signed-off-by: droctothorpe <mythicalsunlight@gmail.com>
Co-authored-by: andreafehrman <andrea.k.fehrman@vanderbilt.edu>
Co-authored-by: owmasch <owenmaschal0598@gmail.com>
Co-authored-by: quinnovator <jack@jq.codes>
Signed-off-by: KevinGrantLee <kglee@google.com>

* feat(component): internal

Signed-off-by: Googler <nobody@google.com>
PiperOrigin-RevId: 663774557
Signed-off-by: KevinGrantLee <kglee@google.com>

* feat(component): internal

Signed-off-by: Googler <nobody@google.com>
PiperOrigin-RevId: 663872006
Signed-off-by: KevinGrantLee <kglee@google.com>

* chore(components): GCPC 2.16.1 Release

Signed-off-by: Googler <nobody@google.com>
PiperOrigin-RevId: 663883139
Signed-off-by: KevinGrantLee <kglee@google.com>

* test: Fail fast when image build fails on tests #11102 (#11115)

* Fail fast when image build fails on tests #11102

Signed-off-by: Elay Aharoni (EXT-Nokia) <elay.aharoni.ext@nokia.com>

* Fail fast when image build fails on tests #11102

Signed-off-by: Elay Aharoni (EXT-Nokia) <elay.aharoni.ext@nokia.com>

---------

Signed-off-by: Elay Aharoni (EXT-Nokia) <elay.aharoni.ext@nokia.com>
Co-authored-by: Elay Aharoni (EXT-Nokia) <elay.aharoni.ext@nokia.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* fix(components): Use instance.target_field_name format for text-bison models only, use target_field_name for gemini models

Signed-off-by: Googler <nobody@google.com>
PiperOrigin-RevId: 665638487
Signed-off-by: KevinGrantLee <kglee@google.com>

* chore: Renamed GitHub workflows from *.yaml to *.yml for consistency (#11126)

Signed-off-by: hbelmiro <helber.belmiro@gmail.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* Fix view edit cluster roles (#11067)

* Fixing incorrect typing in loop_parallism example

Signed-off-by: Oswaldo Gomez <oswaldo.gomez@roche.com>

* Fixing samples/core/loop_parameter example

Signed-off-by: Oswaldo Gomez <oswaldo.gomez@roche.com>

* Fixing aggregate-to-kubeflow-pipelines-edit

Signed-off-by: Oswaldo Gomez <oswaldo.gomez@roche.com>

* keeping MRs separate.

Signed-off-by: Oswaldo Gomez <oswaldo.gomez@roche.com>

* Adding blank line

Signed-off-by: Oswaldo Gomez <oswaldo.gomez@roche.com>

---------

Signed-off-by: Oswaldo Gomez <oswaldo.gomez@roche.com>
Co-authored-by: Oswaldo Gomez <oswaldo.gomez@roche.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* fix(components): Pass moddel name to eval_runner to process batch prediction's output as per the output schema of model used

Signed-off-by: Googler <nobody@google.com>
PiperOrigin-RevId: 665977093
Signed-off-by: KevinGrantLee <kglee@google.com>

* feat(components): release LLM Model Evaluation image version v0.7

Signed-off-by: Jason Dai <jsndai@google.com>
PiperOrigin-RevId: 666102687
Signed-off-by: KevinGrantLee <kglee@google.com>

* chore: Adding @DharmitD to SDK reviewers (#11131)

Signed-off-by: ddalvi <ddalvi@redhat.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* test: Kubeflow Pipelines V2 integration Tests (#11125)

Signed-off-by: Diego Lovison <diegolovison@gmail.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* chore: Add make targets for building driver and launcher images (#11103)

Signed-off-by: Giulio Frasca <gfrasca@redhat.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* feat(Backend + SDK): Update kfp backend and kubernetes sdk to support EmptyDir (#10913)

Update kfp backend and kubernetes sdk to support mounting EmptyDir
volumes to task pods.

Inspired by #10427

Fixes: #10656

Signed-off-by: Greg Sheremeta <gshereme@redhat.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* docs:fixing broken links in readme (#11108)

Signed-off-by: Fiona Waters <fiwaters6@gmail.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* chore(deps): bump micromatch from 4.0.5 to 4.0.8 in /test/frontend-integration-test (#11132)

Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.5 to 4.0.8.
- [Release notes](https://github.com/micromatch/micromatch/releases)
- [Changelog](https://github.com/micromatch/micromatch/blob/4.0.8/CHANGELOG.md)
- [Commits](micromatch/micromatch@4.0.5...4.0.8)

---
updated-dependencies:
- dependency-name: micromatch
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* Fix: Basic sample tests - sequential is flaky (#11138)

Signed-off-by: Diego Lovison <diegolovison@gmail.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* chore: Wrapped "Failed GetContextByTypeAndName" error for better troubleshooting (#11098)

Signed-off-by: hbelmiro <helber.belmiro@gmail.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* chore(components): Update AutoSxS and RLHF image tags

Signed-off-by: Michael Hu <humichael@google.com>
PiperOrigin-RevId: 668536503
Signed-off-by: KevinGrantLee <kglee@google.com>

* test: Improvements to wait_for_pods function (#11162)

Signed-off-by: hbelmiro <helber.belmiro@gmail.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* fix(frontend): fixes filter pipeline text box shows error when typing anything in it. Fixes #10241 (#11096)

* Filter pipeline text box shows error when typing anything in it #10241

Signed-off-by: Elay Aharoni (EXT-Nokia) <elay.aharoni.ext@nokia.com>

* Filter pipeline text box shows error when typing anything in it #10241

Signed-off-by: Elay Aharoni (EXT-Nokia) <elay.aharoni.ext@nokia.com>

---------

Signed-off-by: Elay Aharoni (EXT-Nokia) <elay.aharoni.ext@nokia.com>
Co-authored-by: Elay Aharoni (EXT-Nokia) <elay.aharoni.ext@nokia.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* correct artifact preview behavior in UI (#11059)

This change allows KFP UI to fallback to UI host namespace when no
namespaces are provided when referencing the artifact object store
provider secret, in default kubeflow deployments this namespace is
simply "kubeflow", however the user can customize this behavior by
providing the environment variable "SERVER_NAMESPACE" to the KFP UI
deployment.

Further more, this change addresses a bug that caused URL
parse to fail when parsing endpoints without a protocol, this will
support such endpoint types as <ip>:<port> for object store endpoints,
as is the case in the default kfp deployment manifests.

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* chore: Added DCO link to PR template (#11176)

Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* chore(backend): Update driver and launcher licenses (#11177)

Signed-off-by: Chen Sun <chensun@users.noreply.github.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* chore(backend): update driver and launcher default images (#11178)

Signed-off-by: Chen Sun <chensun@users.noreply.github.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* chore: Add instructions for releasing driver and launcher images (#11179)

Signed-off-by: Chen Sun <chensun@users.noreply.github.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* test: Fixed `kfp-runtime-tests` to run on master branch (#11158)

Signed-off-by: hbelmiro <helber.belmiro@gmail.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* (fix): reduce executor logs (#11169)

* remove driver logs from executor

These logs congest the executor runtime logs making it difficult for the
user to differentiate between logs. The driver logs are unnecessary here
and can be removed to reduce this clutter.

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>

* remove duplicate emissary call in executor

As per the initial inline dev comment, argo podspecpatch did not add the
emissary call, and had to be manualy added. This was fixed a couple of
argo versions back. However, as a result executor pod makes double calls
to the executor, which as a consequence also results in superflous logs.

This change removes the additional call to emissary to resolve this.

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>

---------

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* chore: add PaulinaPacyna and ouadakarim as reviewers (#11180)

Signed-off-by: Chen Sun <chensun@users.noreply.github.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* test: Move run-all-gcpc-modules to GitHub Actions  (#11157)

* add gcpc modules tests to gha

Signed-off-by: Amanpreet Singh Bedi <amanpreet.bedi@zscaler.com>

* remove run-all-gcpc-modules test driver script

Signed-off-by: Amanpreet Singh Bedi <amanpreet.bedi@zscaler.com>

* fix path under gcpc modules tests github action

Signed-off-by: Amanpreet Singh Bedi <amanpreet.bedi@zscaler.com>

* upgrade ubuntu base image

Signed-off-by: Amanpreet Singh Bedi <amanpreet.bedi@zscaler.com>

* upgrade python version to 3.9

Signed-off-by: Amanpreet Singh Bedi <amanpreetsinghbedi23@gmail.com>

---------

Signed-off-by: Amanpreet Singh Bedi <amanpreet.bedi@zscaler.com>
Signed-off-by: Amanpreet Singh Bedi <amanpreetsinghbedi23@gmail.com>
Co-authored-by: Amanpreet Singh Bedi <amanpreet.bedi@zscaler.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* fix(sdk): Kfp support for pip trusted host (#11151)

Signed-off-by: Diego Lovison <diegolovison@gmail.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* chore(sdk): Loosening kubernetes dependency constraint (#11079)

* Loosening kubernetes dependency constraint

Signed-off-by: egeucak <egeucak75@hotmail.com>

* added setuptools in test script

Signed-off-by: egeucak <egeucak75@hotmail.com>

---------

Signed-off-by: egeucak <egeucak75@hotmail.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* chore: Remove unwanted Frontend test files (#10973)

Signed-off-by: ddalvi <ddalvi@redhat.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* fix(ui): fixes empty string value in pipeline parameters (#11175)

Signed-off-by: Jan Staněk <jan@jstanek.cz>
Co-authored-by: Jan Staněk <jan.stanek2@firma.seznam.cz>
Signed-off-by: KevinGrantLee <kglee@google.com>

* chore(backend): update driver and launcher default images (#11182)

Signed-off-by: Chen Sun <chensun@users.noreply.github.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* chore(release): bumped version to 2.3.0

Signed-off-by: KevinGrantLee <kglee@google.com>

* chore: Update RELEASE.md to remove obsolete instructions (#11183)

Signed-off-by: Chen Sun <chensun@users.noreply.github.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* chore: Release kfp-pipeline-spec 0.4.0 (#11189)

Signed-off-by: Chen Sun <chensun@users.noreply.github.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* chore: release kfp-kubernetes 1.3.0 (#11190)

Signed-off-by: Chen Sun <chensun@users.noreply.github.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* chore: update kfp-kubernetes release scripts and instructions (#11191)

Signed-off-by: Chen Sun <chensun@users.noreply.github.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* feat(sdk)!: Pin kfp-pipeline-spec==0.4.0, kfp-server-api>=2.1.0,<2.4.0 (#11192)

Signed-off-by: Chen Sun <chensun@users.noreply.github.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* chore(sdk): release KFP SDK 2.9.0 (#11193)

Signed-off-by: Chen Sun <chensun@users.noreply.github.com>
Signed-off-by: KevinGrantLee <kglee@google.com>

* Delete test pipelines as they are duplicate with
pipeline_with_resource_spec

Signed-off-by: KevinGrantLee <kglee@google.com>

---------

Signed-off-by: KevinGrantLee <kglee@google.com>
Signed-off-by: zazulam <m.zazula@gmail.com>
Signed-off-by: droctothorpe <mythicalsunlight@gmail.com>
Signed-off-by: Googler <nobody@google.com>
Signed-off-by: Giulio Frasca <gfrasca@redhat.com>
Signed-off-by: vmudadla <vmudadla@redhat.com>
Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>
Signed-off-by: Elay Aharoni (EXT-Nokia) <elay.aharoni.ext@nokia.com>
Signed-off-by: hbelmiro <helber.belmiro@gmail.com>
Signed-off-by: Oswaldo Gomez <oswaldo.gomez@roche.com>
Signed-off-by: Jason Dai <jsndai@google.com>
Signed-off-by: ddalvi <ddalvi@redhat.com>
Signed-off-by: Diego Lovison <diegolovison@gmail.com>
Signed-off-by: Greg Sheremeta <gshereme@redhat.com>
Signed-off-by: Fiona Waters <fiwaters6@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Michael Hu <humichael@google.com>
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
Signed-off-by: Chen Sun <chensun@users.noreply.github.com>
Signed-off-by: Amanpreet Singh Bedi <amanpreet.bedi@zscaler.com>
Signed-off-by: Amanpreet Singh Bedi <amanpreetsinghbedi23@gmail.com>
Signed-off-by: egeucak <egeucak75@hotmail.com>
Signed-off-by: Jan Staněk <jan@jstanek.cz>
Co-authored-by: Michael <m.zazula@gmail.com>
Co-authored-by: droctothorpe <mythicalsunlight@gmail.com>
Co-authored-by: andreafehrman <andrea.k.fehrman@vanderbilt.edu>
Co-authored-by: MonicaZhang1 <zhangmonica1@gmail.com>
Co-authored-by: kylekaminky <kyle.kaminky@gmail.com>
Co-authored-by: CarterFendley <carter.fendley@gmail.com>
Co-authored-by: Googler <nobody@google.com>
Co-authored-by: Giulio Frasca <gfrasca@redhat.com>
Co-authored-by: Vani Haripriya Mudadla <vmudadla@redhat.com>
Co-authored-by: Liav Weiss <74174727+liavweiss@users.noreply.github.com>
Co-authored-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>
Co-authored-by: owmasch <owenmaschal0598@gmail.com>
Co-authored-by: quinnovator <jack@jq.codes>
Co-authored-by: ElayAharoni <62550608+ElayAharoni@users.noreply.github.com>
Co-authored-by: Elay Aharoni (EXT-Nokia) <elay.aharoni.ext@nokia.com>
Co-authored-by: Helber Belmiro <helber.belmiro@gmail.com>
Co-authored-by: Oswaldo Gomez <osw.gom89@gmail.com>
Co-authored-by: Oswaldo Gomez <oswaldo.gomez@roche.com>
Co-authored-by: Jason Dai <jsndai@google.com>
Co-authored-by: Dharmit Dalvi <ddalvi@redhat.com>
Co-authored-by: Diego Lovison <diegolovison@gmail.com>
Co-authored-by: Greg Sheremeta <gshereme@redhat.com>
Co-authored-by: Fiona Waters <fiwaters6@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Michael Hu <humichael@google.com>
Co-authored-by: Humair Khan <HumairAK@users.noreply.github.com>
Co-authored-by: Chen Sun <chensun@users.noreply.github.com>
Co-authored-by: aman23bedi <168064369+aman23bedi@users.noreply.github.com>
Co-authored-by: Amanpreet Singh Bedi <amanpreet.bedi@zscaler.com>
Co-authored-by: ege uçak <egeucak75@hotmail.com>
Co-authored-by: Jan Staněk <jan@jstanek.cz>
Co-authored-by: Jan Staněk <jan.stanek2@firma.seznam.cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Closed
Development

No branches or pull requests

8 participants