[UI] Better logging in UI server (#3197)

kubeflow · Mar 3, 2020 · fc13417 · fc13417
1 parent 941f4f5
commit fc13417
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/frontend/server/handlers/artifacts.ts b/frontend/server/handlers/artifacts.ts
@@ -192,7 +192,10 @@ function getGCSArtifactHandler(options: { key: string; bucket: string }) {
         res.send();
         return;
       }
-      console.log(`Found ${matchingFiles.length} matching files:`, matchingFiles);
+      console.log(
+        `Found ${matchingFiles.length} matching files: `,
+        matchingFiles.map(file => file.name).join(','),
+      );
       let contents = '';
       matchingFiles.forEach((f, i) => {
         const buffer: Buffer[] = [];

diff --git a/frontend/server/server.ts b/frontend/server/server.ts
@@ -14,5 +14,12 @@
 import { UIServer } from './app';
 import { loadConfigs } from './configs';
 
-const app = new UIServer(loadConfigs(process.argv, process.env));
+const configs = loadConfigs(process.argv, process.env);
+if (process.env.NODE_ENV !== 'test') {
+  console.log({
+    ...configs,
+    artifacts: 'Artifacts config contains credentials, so it is omitted',
+  });
+}
+const app = new UIServer(configs);
 app.start();
diff --git a/frontend/server/utils.ts b/frontend/server/utils.ts
@@ -58,6 +58,8 @@ export function loadJSON<T>(filepath?: string, defaultValue?: T): T | undefined
   try {
     return JSON.parse(readFileSync(filepath, 'utf-8'));
   } catch (error) {
+    console.error(`Failed reading json data from '${filepath}':`);
+    console.error(error);
     return defaultValue;
   }
 }