Skip to content

Commit

Permalink
A more accurate grpc error code for duplicate pipeline/pipeline versi…
Browse files Browse the repository at this point in the history
…on/experiment names (#3846)

* a more accurate grpc error code

* remove accidentally checked in file
  • Loading branch information
jingzhang36 authored May 27, 2020
1 parent 3fe9b7e commit ef73aab
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion backend/src/apiserver/storage/experiment_store.go
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ func (s *ExperimentStore) CreateExperiment(experiment *model.Experiment) (*model
_, err = s.db.Exec(sql, args...)
if err != nil {
if s.db.IsDuplicateError(err) {
return nil, util.NewInvalidInputError(
return nil, util.NewAlreadyExistError(
"Failed to create a new experiment. The name %v already exists. Please specify a new name.", experiment.Name)
}
return nil, util.NewInternalServerError(err, "Failed to add experiment to experiment table: %v",
Expand Down
6 changes: 3 additions & 3 deletions backend/src/apiserver/storage/pipeline_store.go
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ func (s *PipelineStore) CreatePipeline(p *model.Pipeline) (*model.Pipeline, erro
if err != nil {
if s.db.IsDuplicateError(err) {
tx.Rollback()
return nil, util.NewInvalidInputError(
return nil, util.NewAlreadyExistError(
"Failed to create a new pipeline. The name %v already exist. Please specify a new name.", p.Name)
}
tx.Rollback()
Expand All @@ -342,7 +342,7 @@ func (s *PipelineStore) CreatePipeline(p *model.Pipeline) (*model.Pipeline, erro
if err != nil {
if s.db.IsDuplicateError(err) {
tx.Rollback()
return nil, util.NewInvalidInputError(
return nil, util.NewAlreadyExistError(
`Failed to create a new pipeline version. The name %v already
exist. Please specify a new name.`, p.DefaultVersion.Name)
}
Expand Down Expand Up @@ -500,7 +500,7 @@ func (s *PipelineStore) CreatePipelineVersion(v *model.PipelineVersion) (*model.
if err != nil {
tx.Rollback()
if s.db.IsDuplicateError(err) {
return nil, util.NewInvalidInputError(
return nil, util.NewAlreadyExistError(
"Failed to create a new pipeline version. The name %v already exist. Please specify a new name.", v.Name)
}
return nil, util.NewInternalServerError(err, "Failed to add version to pipeline version table: %v",
Expand Down

0 comments on commit ef73aab

Please sign in to comment.