Skip to content

Commit

Permalink
two fixes (#3307)
Browse files Browse the repository at this point in the history
  • Loading branch information
Jiaxiao Zheng authored Mar 19, 2020
1 parent 19edfde commit db8a236
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
6 changes: 6 additions & 0 deletions test/presubmit-tests-with-pipeline-deployment.sh
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ usage()
[--test_result_bucket the gcs bucket that argo workflow store the result to. Default is ml-pipeline-test
[--test_result_folder the gcs folder that argo workflow store the result to. Always a relative directory to gs://<gs_bucket>/[PULL_SHA]]
[--timeout timeout of the tests in seconds. Default is 1800 seconds. ]
[--is_integration_test] if true, integration test cases will be invoked.
[-h help]"
}

Expand All @@ -34,6 +35,7 @@ TEST_RESULT_BUCKET=ml-pipeline-test
TIMEOUT_SECONDS=2700 # 45 minutes
NAMESPACE=kubeflow
ENABLE_WORKLOAD_IDENTITY=true
IS_INTEGRATION_TEST=false

while [ "$1" != "" ]; do
case $1 in
Expand All @@ -55,6 +57,9 @@ while [ "$1" != "" ]; do
--timeout ) shift
TIMEOUT_SECONDS=$1
;;
--is_integration_test ) shift
IS_INTEGRATION_TEST=$1
;;
-h | --help ) usage
exit
;;
Expand Down Expand Up @@ -108,6 +113,7 @@ ARGO_WORKFLOW=`argo submit ${DIR}/${WORKFLOW_FILE} \
${IMAGE_BUILDER_ARG} \
-p target-image-prefix="${GCR_IMAGE_BASE_DIR}/" \
-p test-results-gcs-dir="${TEST_RESULTS_GCS_DIR}" \
-p is-integration-test="${IS_INTEGRATION_TEST}" \
-n ${NAMESPACE} \
--serviceaccount test-runner \
-o name
Expand Down
1 change: 0 additions & 1 deletion test/sample_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ spec:
- loop_static
- resource_ops
- multiple_outputs
when: "{{inputs.parameters.is-integration-test}} == false"
- name: run-integration-tests-loop
template: run-sample-tests
arguments:
Expand Down

0 comments on commit db8a236

Please sign in to comment.