Skip to content

Commit

Permalink
Pin tensorboard version to 1.13.2 (#2513)
Browse files Browse the repository at this point in the history
* Pin tensorboard version to 1.13.2

Using latest causes various uncertainties due to tensorflow backward incompatibility especially new 2.0.
In long term we should allow user specify the tensorboard image version. 
/assign @numerology 
cc @jingzhang36

* Update reconciler.go

* Update reconciler.go

* Update reconciler_test.go

* Update reconciler_test.go
  • Loading branch information
IronPan authored and k8s-ci-robot committed Oct 30, 2019
1 parent af090bf commit 94b0431
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
6 changes: 4 additions & 2 deletions backend/src/crd/controller/viewer/reconciler/reconciler.go
Original file line number Diff line number Diff line change
Expand Up @@ -165,12 +165,14 @@ func setPodSpecForTensorboard(view *viewerV1beta1.Viewer, s *corev1.PodSpec) {

c := &s.Containers[0]
c.Name = view.Name + "-pod"
c.Image = "tensorflow/tensorflow"
c.Image = "tensorflow/tensorflow:1.13.2"
c.Args = []string{
"tensorboard",
fmt.Sprintf("--logdir=%s", view.Spec.TensorboardSpec.LogDir),
fmt.Sprintf("--path_prefix=/tensorboard/%s/", view.Name),
"--bind_all",
// This is needed for tf 2.0. We need to optionally add it
// when https://github.com/kubeflow/pipelines/issues/2514 is done
// "--bind_all",
}
c.Ports = []corev1.ContainerPort{
corev1.ContainerPort{ContainerPort: viewerTargetPort},
Expand Down
10 changes: 4 additions & 6 deletions backend/src/crd/controller/viewer/reconciler/reconciler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -174,12 +174,11 @@ func TestReconcile_EachViewerCreatesADeployment(t *testing.T) {
Spec: corev1.PodSpec{
Containers: []corev1.Container{{
Name: "viewer-123-pod",
Image: "tensorflow/tensorflow",
Image: "tensorflow/tensorflow:1.13.2",
Args: []string{
"tensorboard",
"--logdir=gs://tensorboard/logdir",
"--path_prefix=/tensorboard/viewer-123/",
"--bind_all"},
"--path_prefix=/tensorboard/viewer-123/"},
Ports: []corev1.ContainerPort{{ContainerPort: 6006}},
}}}}}}}

Expand Down Expand Up @@ -272,12 +271,11 @@ func TestReconcile_ViewerUsesSpecifiedVolumeMountsForDeployment(t *testing.T) {
Spec: corev1.PodSpec{
Containers: []corev1.Container{{
Name: "viewer-123-pod",
Image: "tensorflow/tensorflow",
Image: "tensorflow/tensorflow:1.13.2",
Args: []string{
"tensorboard",
"--logdir=gs://tensorboard/logdir",
"--path_prefix=/tensorboard/viewer-123/",
"--bind_all"},
"--path_prefix=/tensorboard/viewer-123/"},
Ports: []corev1.ContainerPort{{ContainerPort: 6006}},
VolumeMounts: []v1.VolumeMount{
{Name: "/volume-mount-name", MountPath: "/mount/path"},
Expand Down

0 comments on commit 94b0431

Please sign in to comment.