Skip to content

Commit

Permalink
Fixed incorrect image names
Browse files Browse the repository at this point in the history
  • Loading branch information
ajchili committed Aug 30, 2019
1 parent ca46d40 commit 6d26572
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 8 deletions.
9 changes: 5 additions & 4 deletions test/build-images.sh
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,12 @@ if
echo "$BUILT_IMAGES" | grep frontend && \
echo "$BUILT_IMAGES" | grep scheduledworkflow && \
echo "$BUILT_IMAGES" | grep persistenceagent && \
echo "$BUILT_IMAGES" | grep viewer-crd && \
echo "$BUILT_IMAGES" | grep visualizationserver;
echo "$BUILT_IMAGES" | grep viewer-crd-controller && \
echo "$BUILT_IMAGES" | grep visualization-server;
then
echo "docker images for api-server, frontend, scheduledworkflow and \
persistenceagent are already built in ${GCR_IMAGE_BASE_DIR}."
echo "docker images for api-server, frontend, scheduledworkflow, \
persistenceagent, viewer-crd-controller, and visualization-server \
are already built in ${GCR_IMAGE_BASE_DIR}."
else
echo "submitting cloud build to build docker images for commit ${PULL_PULL_SHA}..."
IMAGES_BUILDING=true
Expand Down
4 changes: 2 additions & 2 deletions test/cloudbuild/batch_build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ steps:
waitFor: ["-"]
- name: "gcr.io/cloud-builders/docker"
args:
["build", "-t", "$_GCR_BASE/viewer-crd", "-f", "backend/Dockerfile.viewercontroller", "."]
["build", "-t", "$_GCR_BASE/viewer-crd-controller", "-f", "backend/Dockerfile.viewercontroller", "."]
waitFor: ["-"]
- name: "gcr.io/cloud-builders/docker"
args:
["build", "-t", "$_GCR_BASE/visualizationserver", "-f", "backend/Dockerfile.visualization", "."]
["build", "-t", "$_GCR_BASE/visualization-server", "-f", "backend/Dockerfile.visualization", "."]
waitFor: ["-"]
options:
machineType: N1_HIGHCPU_8 # use a fast machine to build because there a lot of work
Expand Down
4 changes: 2 additions & 2 deletions test/deploy-pipeline-lite.sh
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ kustomize edit set image gcr.io/ml-pipeline/api-server=${GCR_IMAGE_BASE_DIR}/api
kustomize edit set image gcr.io/ml-pipeline/persistenceagent=${GCR_IMAGE_BASE_DIR}/persistenceagent:${GCR_IMAGE_TAG}
kustomize edit set image gcr.io/ml-pipeline/scheduledworkflow=${GCR_IMAGE_BASE_DIR}/scheduledworkflow:${GCR_IMAGE_TAG}
kustomize edit set image gcr.io/ml-pipeline/frontend=${GCR_IMAGE_BASE_DIR}/frontend:${GCR_IMAGE_TAG}
kustomize edit set image gcr.io/ml-pipeline/viewer-crd=${GCR_IMAGE_BASE_DIR}/viewer-crd:${GCR_IMAGE_TAG}
kustomize edit set image gcr.io/ml-pipeline/visualizationserver=${GCR_IMAGE_BASE_DIR}/visualizationserver:${GCR_IMAGE_TAG}
kustomize edit set image gcr.io/ml-pipeline/viewer-crd-controller=${GCR_IMAGE_BASE_DIR}/viewer-crd-controller:${GCR_IMAGE_TAG}
kustomize edit set image gcr.io/ml-pipeline/visualization-server=${GCR_IMAGE_BASE_DIR}/visualization-server:${GCR_IMAGE_TAG}
cat kustomization.yaml

kustomize build . | kubectl apply -f -
Expand Down

0 comments on commit 6d26572

Please sign in to comment.