Skip to content

Commit

Permalink
[Testing] KFP standalone test infra for upgradability (#1971)
Browse files Browse the repository at this point in the history
* Implement upgrade test

* mark upgrade-tests.sh as executable

* Fix comments

* Base upgrade_test_setup.yaml

* e2e integration of upgrade test

* Fix entrypoint argument

* Fix e2e workflow yaml

* Fix run_test.sh argument processing

* Fix no closing backtick

* Restrucutre upgrade_test.go to focus the test on upgrade verification

* clean up code

* Clean up after upgrade test when it is run in integration tests.

* Include pipeline tests in upgrade test

* Reorder tests

* Add upgrade test coverage for run api resources

* Add job api resource coverage in upgrade test & refactored upgrade test

* Fix add missing step in upgrade test

* Fix BUILD.bazel

* Fix upgrade_test.go

* Try to fix upgrade test failure

* Fix hard coded namespace

* Sync upgrade-tests.sh with new changes in presubmit-tests-with-pipeline-deployment.sh

* Update upgrade test

* Remove redundant code

* Fix integration test exit code

* Fix trigger interval second mismatch
  • Loading branch information
Bobgy authored Mar 9, 2020
1 parent 788c379 commit 5391e88
Show file tree
Hide file tree
Showing 12 changed files with 842 additions and 39 deletions.
2 changes: 1 addition & 1 deletion backend/src/apiserver/server/api_converter.go
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ func toApiTrigger(trigger model.Trigger) *api.Trigger {
return &api.Trigger{Trigger: &api.Trigger_CronSchedule{CronSchedule: &cronSchedule}}
}

if trigger.IntervalSecond != nil {
if trigger.IntervalSecond != nil && *trigger.IntervalSecond != 0 {
var periodicSchedule api.PeriodicSchedule
periodicSchedule.IntervalSecond = *trigger.IntervalSecond
if trigger.PeriodicScheduleStartTimeInSec != nil {
Expand Down
2 changes: 2 additions & 0 deletions backend/test/integration/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ go_test(
"pipeline_api_test.go",
"pipeline_version_api_test.go",
"run_api_test.go",
"upgrade_test.go",
"visualization_api_test.go",
],
embed = [":go_default_library"],
Expand All @@ -32,6 +33,7 @@ go_test(
"@com_github_go_openapi_strfmt//:go_default_library",
"@com_github_golang_glog//:go_default_library",
"@com_github_stretchr_testify//assert:go_default_library",
"@com_github_stretchr_testify//require:go_default_library",
"@com_github_stretchr_testify//suite:go_default_library",
"@io_k8s_apimachinery//pkg/util/yaml:go_default_library",
"@org_golang_google_grpc//:go_default_library",
Expand Down
1 change: 1 addition & 0 deletions backend/test/integration/flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
var namespace = flag.String("namespace", "kubeflow", "The namespace ml pipeline deployed to")
var initializeTimeout = flag.Duration("initializeTimeout", 2*time.Minute, "Duration to wait for test initialization")
var runIntegrationTests = flag.Bool("runIntegrationTests", false, "Whether to also run integration tests that call the service")
var runUpgradeTests = flag.Bool("runUpgradeTests", false, "Whether to run upgrade tests")

/**
* Differences in dev mode:
Expand Down
Loading

0 comments on commit 5391e88

Please sign in to comment.