Workaround error thrown from metadata server when there is no record (#…

…2126)
kubeflow · Sep 16, 2019 · 49834c4 · 49834c4
1 parent 33f4244
commit 49834c4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/frontend/src/pages/ArtifactList.tsx b/frontend/src/pages/ArtifactList.tsx
@@ -103,7 +103,9 @@ class ArtifactList extends Page<{}, ArtifactListState> {
 
   private async reload(request: ListRequest): Promise<string> {
     Apis.getMetadataServiceClient().getArtifacts(new GetArtifactsRequest(), (err, res) => {
-      if (err) {
+      // Code === 5 means no record found in backend. This is a temporary workaround.
+      // TODO: remove err.code !== 5 check when backend is fixed.
+      if (err && err.code !== 5) {
         this.showPageError(serviceErrorToString(err));
         return;
       }
@@ -129,7 +131,7 @@ class ArtifactList extends Page<{}, ArtifactListState> {
           {props.value}
         </Link>
       );
-  }
+    }
 
   /**
    * Temporary solution to apply sorting, filtering, and pagination to the

diff --git a/frontend/src/pages/ExecutionList.tsx b/frontend/src/pages/ExecutionList.tsx
@@ -101,7 +101,9 @@ class ExecutionList extends Page<{}, ExecutionListState> {
 
   private async reload(request: ListRequest): Promise<string> {
     Apis.getMetadataServiceClient().getExecutions(new GetExecutionsRequest(), (err, res) => {
-      if (err) {
+      // Code === 5 means no record found in backend. This is a temporary workaround.
+      // TODO: remove err.code !== 5 check when backend is fixed.
+      if (err && err.code !== 5) {
         this.showPageError(serviceErrorToString(err));
         return;
       }
@@ -126,7 +128,7 @@ class ExecutionList extends Page<{}, ExecutionListState> {
           {props.value}
         </Link>
       );
-  }
+    }
 
   /**
    * Temporary solution to apply sorting, filtering, and pagination to the