Skip to content

Commit

Permalink
minor styling fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
eterna2 committed Oct 14, 2019
1 parent 7a3cfc2 commit 2b7e57f
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions frontend/src/lib/StaticGraphParser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export function _populateInfoFromTemplate(info: SelectedNodeInfo, template?: Tem
info.args = template.container.args || [],
info.command = template.container.command || [],
info.image = template.container.image || '';
info.volumeMounts = (template.container.volumeMounts || []).map(v => [v.mountPath, v.name] );
info.volumeMounts = (template.container.volumeMounts || []).map(v => [v.mountPath, v.name]);
} else {
info.nodeType = 'resource';
if (template.resource && template.resource.action && template.resource.manifest) {
Expand All @@ -83,7 +83,7 @@ export function _populateInfoFromTemplate(info: SelectedNodeInfo, template?: Tem
} else if (p.valueFrom) {
value = p.valueFrom.jqFilter || p.valueFrom.jsonPath || p.valueFrom.parameter || p.valueFrom.path || '';
}
return [p.name, value] ;
return [p.name, value];
});
}

Expand Down
14 changes: 7 additions & 7 deletions frontend/src/lib/WorkflowParser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -170,18 +170,18 @@ export default class WorkflowParser {
// inputs/outputs if any, while looking out for any missing link in the chain to
// the node's inputs/outputs.
public static getNodeInputOutputParams(workflow?: Workflow, nodeId?: string): [Array<KeyValue<string>>, Array<KeyValue<string>>] {
type paramList = Array<KeyValue<string>>;
type ParamList = Array<KeyValue<string>>;
if (!nodeId || !workflow || !workflow.status || !workflow.status.nodes || !workflow.status.nodes[nodeId]) {
return [[], []];
}

const node = workflow.status.nodes[nodeId];
const inputsOutputs: [paramList, paramList] = [[], []];
if (node.inputs && node.inputs.parameters) {
inputsOutputs[0] = node.inputs.parameters.map(p => [p.name, p.value || ''] );
inputsOutputs[0] = node.inputs.parameters.map(p => [p.name, p.value || '']);
}
if (node.outputs && node.outputs.parameters) {
inputsOutputs[1] = node.outputs.parameters.map(p => [p.name, p.value || ''] );
inputsOutputs[1] = node.outputs.parameters.map(p => [p.name, p.value || '']);
}
return inputsOutputs;
}
Expand All @@ -190,18 +190,18 @@ export default class WorkflowParser {
// inputs/outputs artifacts if any, while looking out for any missing link in the chain to
// the node's inputs/outputs.
public static getNodeInputOutputArtifacts(workflow?: Workflow, nodeId?: string): [Array<KeyValue<S3Artifact>>, Array<KeyValue<S3Artifact>>] {
type paramList = Array<KeyValue<S3Artifact>>;
type ParamList = Array<KeyValue<S3Artifact>>;
if (!nodeId || !workflow || !workflow.status || !workflow.status.nodes || !workflow.status.nodes[nodeId]) {
return [[], []];
}

const node = workflow.status.nodes[nodeId];
const inputsArtifacts: [paramList, paramList] = [[], []];
if (node.inputs && node.inputs.artifacts) {
inputsArtifacts[0] = node.inputs.artifacts.map(p => [p.name, p.s3] );
inputsArtifacts[0] = node.inputs.artifacts.map(p => [p.name, p.s3]);
}
if (node.outputs && node.outputs.artifacts) {
inputsArtifacts[1] = node.outputs.artifacts.map(p => [p.name, p.s3] );
inputsArtifacts[1] = node.outputs.artifacts.map(p => [p.name, p.s3]);
}
return inputsArtifacts;
}
Expand All @@ -217,7 +217,7 @@ export default class WorkflowParser {
const tmpl = workflow.spec.templates.find(t => !!t && !!t.name && t.name === node.templateName);
let volumeMounts: Array<KeyValue<string>> = [];
if (tmpl && tmpl.container && tmpl.container.volumeMounts) {
volumeMounts = tmpl.container.volumeMounts.map(v => [v.mountPath, v.name] );
volumeMounts = tmpl.container.volumeMounts.map(v => [v.mountPath, v.name]);
}
return volumeMounts;
}
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/pages/RecurringRunDetails.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ class RecurringRunDetails extends Page<{}, RecurringRunConfigState> {
['Description', run.description!],
['Created at', formatDateString(run.created_at)],
];
inputParameters = (run.pipeline_spec.parameters || []).map(p => [p.name || '', p.value || ''] );
inputParameters = (run.pipeline_spec.parameters || []).map(p => [p.name || '', p.value || '']);
if (run.trigger) {
triggerDetails = [
['Enabled', enabledDisplayString(run.trigger, run.enabled!)],
Expand Down

0 comments on commit 2b7e57f

Please sign in to comment.