Skip to content

Commit

Permalink
Build inverse proxy image as part of the presubmit test (#2187)
Browse files Browse the repository at this point in the history
* small fixes

* add

* Delete Makefile
  • Loading branch information
IronPan authored and k8s-ci-robot committed Sep 21, 2019
1 parent 0459ff9 commit 0711566
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
3 changes: 2 additions & 1 deletion test/build-images.sh
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,11 @@ if
echo "$BUILT_IMAGES" | grep scheduledworkflow && \
echo "$BUILT_IMAGES" | grep persistenceagent && \
echo "$BUILT_IMAGES" | grep viewer-crd-controller && \
echo "$BUILT_IMAGES" | grep inverse-proxy-agent && \
echo "$BUILT_IMAGES" | grep visualization-server;
then
echo "docker images for api-server, frontend, scheduledworkflow, \
persistenceagent, viewer-crd-controller, and visualization-server \
persistenceagent, viewer-crd-controller, inverse-proxy-agent, and visualization-server \
are already built in ${GCR_IMAGE_BASE_DIR}."
else
echo "submitting cloud build to build docker images for commit ${PULL_PULL_SHA}..."
Expand Down
4 changes: 4 additions & 0 deletions test/cloudbuild/batch_build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ steps:
args:
["build", "-t", "$_GCR_BASE/visualization-server", "-f", "backend/Dockerfile.visualization", "."]
waitFor: ["-"]
- name: "gcr.io/cloud-builders/docker"
args:
["build", "-t", "$_GCR_BASE/inverse-proxy-agent", "-f", "proxy/Dockerfile", "."]
waitFor: ["-"]
options:
machineType: N1_HIGHCPU_8 # use a fast machine to build because there a lot of work
images:
Expand Down
1 change: 1 addition & 0 deletions test/deploy-pipeline-lite.sh
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ kustomize edit set image gcr.io/ml-pipeline/scheduledworkflow=${GCR_IMAGE_BASE_D
kustomize edit set image gcr.io/ml-pipeline/frontend=${GCR_IMAGE_BASE_DIR}/frontend:${GCR_IMAGE_TAG}
kustomize edit set image gcr.io/ml-pipeline/viewer-crd-controller=${GCR_IMAGE_BASE_DIR}/viewer-crd-controller:${GCR_IMAGE_TAG}
kustomize edit set image gcr.io/ml-pipeline/visualization-server=${GCR_IMAGE_BASE_DIR}/visualization-server:${GCR_IMAGE_TAG}
kustomize edit set image gcr.io/ml-pipeline/inverse-proxy-agent=${GCR_IMAGE_BASE_DIR}/inverse-proxy-agent:${GCR_IMAGE_TAG}
cat kustomization.yaml

kustomize build . | kubectl apply -f -
Expand Down

0 comments on commit 0711566

Please sign in to comment.