Skip to content

Commit

Permalink
(fix): reduce executor logs (#11169)
Browse files Browse the repository at this point in the history
* remove driver logs from executor

These logs congest the executor runtime logs making it difficult for the
user to differentiate between logs. The driver logs are unnecessary here
and can be removed to reduce this clutter.

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>

* remove duplicate emissary call in executor

As per the initial inline dev comment, argo podspecpatch did not add the
emissary call, and had to be manualy added. This was fixed a couple of
argo versions back. However, as a result executor pod makes double calls
to the executor, which as a consequence also results in superflous logs.

This change removes the additional call to emissary to resolve this.

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>

---------

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Signed-off-by: KevinGrantLee <kglee@google.com>
  • Loading branch information
HumairAK authored and KevinGrantLee committed Sep 17, 2024
1 parent 17b55a3 commit 066e8b5
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
1 change: 0 additions & 1 deletion backend/src/v2/component/launcher_v2.go
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ func NewLauncherV2(ctx context.Context, executionID int64, executorInputJSON, co
if err != nil {
return nil, fmt.Errorf("failed to unmarshal executor input: %w", err)
}
glog.Infof("input ComponentSpec:%s\n", prettyPrint(componentSpecJSON))
component := &pipelinespec.ComponentSpec{}
err = protojson.Unmarshal([]byte(componentSpecJSON), component)
if err != nil {
Expand Down
3 changes: 0 additions & 3 deletions backend/src/v2/driver/driver.go
Original file line number Diff line number Diff line change
Expand Up @@ -387,9 +387,6 @@ func initPodSpecPatch(
userCmdArgs = append(userCmdArgs, container.Command...)
userCmdArgs = append(userCmdArgs, container.Args...)
launcherCmd := []string{
// TODO(Bobgy): workaround argo emissary executor bug, after we upgrade to an argo version with the bug fix, we can remove the following line.
// Reference: https://github.com/argoproj/argo-workflows/issues/7406
"/var/run/argo/argoexec", "emissary", "--",
component.KFPLauncherPath,
// TODO(Bobgy): no need to pass pipeline_name and run_id, these info can be fetched via pipeline context and pipeline run context which have been created by root DAG driver.
"--pipeline_name", pipelineName,
Expand Down

0 comments on commit 066e8b5

Please sign in to comment.