Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebooks 2.0 // Frontend // Workspaces table // Workspace Kind column #148

Closed
paulovmr opened this issue Dec 4, 2024 · 5 comments
Closed
Assignees

Comments

@paulovmr
Copy link

paulovmr commented Dec 4, 2024

Modify the "Kind" column to show an icon representing the WorkspaceKind instead of its displayName. The icon URL will come from here.

@liavweiss
Copy link

/assign

liavweiss pushed a commit to liavweiss/notebooks that referenced this issue Dec 26, 2024
liavweiss pushed a commit to liavweiss/notebooks that referenced this issue Jan 8, 2025
liavweiss pushed a commit to liavweiss/notebooks that referenced this issue Jan 9, 2025
Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>
liavweiss pushed a commit to liavweiss/notebooks that referenced this issue Jan 14, 2025
Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>
liavweiss pushed a commit to liavweiss/notebooks that referenced this issue Jan 14, 2025
…Kind column kubeflow#148

Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>
liavweiss pushed a commit to liavweiss/notebooks that referenced this issue Jan 21, 2025
Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>
liavweiss pushed a commit to liavweiss/notebooks that referenced this issue Jan 23, 2025
…Kind column kubeflow#148

Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>
liavweiss pushed a commit to liavweiss/notebooks that referenced this issue Jan 23, 2025
…Kind column kubeflow#148

Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>
liavweiss pushed a commit to liavweiss/notebooks that referenced this issue Jan 26, 2025
…Kind column kubeflow#148

Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>
liavweiss pushed a commit to liavweiss/notebooks that referenced this issue Jan 26, 2025
Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>
liavweiss pushed a commit to liavweiss/notebooks that referenced this issue Jan 26, 2025
…Kind column kubeflow#148

Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>
liavweiss pushed a commit to liavweiss/notebooks that referenced this issue Jan 26, 2025
…Kind column kubeflow#148

Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>
liavweiss pushed a commit to liavweiss/notebooks that referenced this issue Jan 26, 2025
…Kind column kubeflow#148

Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>
liavweiss pushed a commit to liavweiss/notebooks that referenced this issue Jan 28, 2025
…Kind column kubeflow#148

Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>
liavweiss pushed a commit to liavweiss/notebooks that referenced this issue Jan 28, 2025
…Kind column kubeflow#148

Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>
liavweiss pushed a commit to liavweiss/notebooks that referenced this issue Jan 29, 2025
…Kind column kubeflow#148

Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>
google-oss-prow bot pushed a commit that referenced this issue Jan 29, 2025
…Kind column #148 (#177)

* Merge notebooks-v2 into kind_logo_modification/#148 branch

Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>

* feat(ws): Notebooks 2.0 // Frontend // Workspaces table // Workspace Kind column #148

Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>

* feat(ws): Notebooks 2.0 // Frontend // Workspaces table // Workspace Kind column #148

Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>

* feat(ws): Notebooks 2.0 // Frontend // Workspaces table // Workspace Kind column #148

Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>

* feat(ws): Notebooks 2.0 // Frontend // Workspaces table // Workspace Kind column #148

Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>

* feat(ws): Notebooks 2.0 // Frontend // Workspaces table // Workspace Kind column #148

Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>

* feat(ws): Notebooks 2.0 // Frontend // Workspaces table // Workspace Kind column #148

Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>

---------

Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>
Co-authored-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>
asaadbalum pushed a commit to asaadbalum/notebooks that referenced this issue Feb 6, 2025
…Kind column kubeflow#148 (kubeflow#177)

* Merge notebooks-v2 into kind_logo_modification/kubeflow#148 branch

Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>

* feat(ws): Notebooks 2.0 // Frontend // Workspaces table // Workspace Kind column kubeflow#148

Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>

* feat(ws): Notebooks 2.0 // Frontend // Workspaces table // Workspace Kind column kubeflow#148

Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>

* feat(ws): Notebooks 2.0 // Frontend // Workspaces table // Workspace Kind column kubeflow#148

Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>

* feat(ws): Notebooks 2.0 // Frontend // Workspaces table // Workspace Kind column kubeflow#148

Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>

* feat(ws): Notebooks 2.0 // Frontend // Workspaces table // Workspace Kind column kubeflow#148

Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>

* feat(ws): Notebooks 2.0 // Frontend // Workspaces table // Workspace Kind column kubeflow#148

Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>

---------

Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>
Co-authored-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>
Signed-off-by: Asaad <asaad.balum@gmail.com>
asaadbalum pushed a commit to asaadbalum/notebooks that referenced this issue Feb 6, 2025
…Kind column kubeflow#148 (kubeflow#177)

* Merge notebooks-v2 into kind_logo_modification/kubeflow#148 branch

Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>

* feat(ws): Notebooks 2.0 // Frontend // Workspaces table // Workspace Kind column kubeflow#148

Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>

* feat(ws): Notebooks 2.0 // Frontend // Workspaces table // Workspace Kind column kubeflow#148

Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>

* feat(ws): Notebooks 2.0 // Frontend // Workspaces table // Workspace Kind column kubeflow#148

Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>

* feat(ws): Notebooks 2.0 // Frontend // Workspaces table // Workspace Kind column kubeflow#148

Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>

* feat(ws): Notebooks 2.0 // Frontend // Workspaces table // Workspace Kind column kubeflow#148

Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>

* feat(ws): Notebooks 2.0 // Frontend // Workspaces table // Workspace Kind column kubeflow#148

Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>

---------

Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>
Co-authored-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>
@liavweiss
Copy link

PR was merged, please close the ticket.

Copy link

@liavweiss: You can't close an active issue/PR unless you authored it or you are a collaborator.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ElayAharoni
Copy link

/close

Copy link

@ElayAharoni: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-project-automation github-project-automation bot moved this from To Do to Done in Kubeflow Notebooks Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants