Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebooks 2.0 // Frontend // Workspaces table // Start, restart and stop workspace #146

Closed
paulovmr opened this issue Dec 4, 2024 · 6 comments
Assignees

Comments

@paulovmr
Copy link

paulovmr commented Dec 4, 2024

Implement Start, restart and stop workspace actions present in the workspace table actions kebab dropdown.

If workspace is running:

  • Stop action: display warning popup about unsaved work.
    • If there is a pending update:
      • Buttons: "Stop and update", "Stop and defer update", "Cancel".
    • If there is NOT a pending update:
      • Buttons: "Stop", "Cancel".
  • Restart action: display warning popup about unsaved work.
    • If there is a pending update:
      • Buttons: "Update and restart", "Only restart", "Cancel".
    • If there is NOT a pending update:
      • Buttons: "Restart", "Cancel".

If workspace is not running:

  • Start action:
    • If there is a pending update: display warning popup about unsaved work.
      • Buttons: "Update and start", "Only start", "Cancel".
    • If there is NOT a pending update, start workbench directly.
@ElayAharoni
Copy link

/assign

@Aman123lug
Copy link

@ElayAharoni Are you still working on this issue?

@Aman123lug
Copy link

/assign

@ElayAharoni
Copy link

@Aman123lug this issue needs to be closed as this pr: #162 solveing it and it is merged

@ElayAharoni
Copy link

/close

Copy link

@ElayAharoni: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-project-automation github-project-automation bot moved this from To Do to Done in Kubeflow Notebooks Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants