Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(csi): restructure the CSI as different mr executable #601

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

lampajr
Copy link
Member

@lampajr lampajr commented Nov 29, 2024

Fixes #338

Description

With this PR I am proposing a possible solution to the way CSI is managed here (ref. #338).

Instead of having a separate Go module, I am just proposing to simply create a new executable in a dedicated folder that makes use of model registry source code (as it was previously though)

This should completely remove the issue we were encountaring with false negative on dependabot.

Pro

  • Nothing changed wrt the previous approach in terms of deliverable
  • A tagged release of model registry contains both source code for MR itself and CSI
  • Model registry and CSI container images are in sync in terms of release version and source code
  • The CSI does not explicitly pin any version of model registry as it directly uses the model registry source code (as it was before but without any confusion)
  • The maintenance is a lot eaiser, just one module for both

Cons

  • I had to add kserve dependency in the model registry even if for the model-registry itself is not actually required

How Has This Been Tested?

Updated the existing CI tests

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
@lampajr lampajr marked this pull request as ready for review December 4, 2024 16:39
@google-oss-prow google-oss-prow bot requested a review from ckadner December 4, 2024 16:39
@lampajr
Copy link
Member Author

lampajr commented Dec 4, 2024

/cc @Al-Pragliola @tarilabs

As discussed in slack, here the final proposal with the suggested changes 🚀

@lampajr lampajr changed the title Restructure the CSI as different executable feat(csi): restructure the CSI as different mr executable Dec 4, 2024
Copy link
Contributor

@Al-Pragliola Al-Pragliola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I will close #598 in favor of this, thank you for taking care of this issue 🙏

All tests pass locally and on CI, I also checked possible differences in image size and everything works as intended.

MR pre refactoring
image
MR post refactoring
image

CSI pre refactoring
image
CSI post refactoring
image

Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per discussions in the KF Model Registry biweekly meeting last 2024-12-09, thanks a lot @lampajr for these contributions and thank you @Al-Pragliola for the great help too

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Al-Pragliola, tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 4cc309b into kubeflow:main Dec 11, 2024
17 checks passed
@lampajr lampajr deleted the csi_restructure branch December 11, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor CSI as different command of the model registry module
3 participants