Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py: client: add logging #563

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

isinyaaa
Copy link
Contributor

Adds logging and additional keyword args to the Python client.
This also makes the custom_ca totally optional and not sourced by default by any means.

Logging settings can be further extended (e.g. with a prefix path for file logging) using other constructor flags.

Description

How Has This Been Tested?

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Co-authored-by: Luca Giorgi <lgiorgi@redhat.com>
Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @isinyaaa !

/lgtm

I've added some comments for considerations; cc @lugi0

clients/python/src/model_registry/_client.py Outdated Show resolved Hide resolved
clients/python/src/model_registry/_client.py Show resolved Hide resolved
clients/python/src/model_registry/_client.py Outdated Show resolved Hide resolved
Co-authored-by: Matteo Mortari <matteo.mortari@gmail.com>
Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
@google-oss-prow google-oss-prow bot removed the lgtm label Nov 18, 2024
@isinyaaa isinyaaa requested a review from tarilabs November 18, 2024 16:39
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Nov 26, 2024
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 3285729 into kubeflow:main Nov 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants