-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: InferenceService reconcile function #541
Feat: InferenceService reconcile function #541
Conversation
Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
bf7166c
to
fee2381
Compare
Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much @Al-Pragliola!
I assume this is tested by importing into other controllers and it's working, and that tests will be made here upstream in following PRs?
if that is correct for both, and
/lgtm
with the intent to close this PR early, to ease follow-up works/tasks
/approve cancel |
thanks @tarilabs yes exactly as you said, I have updated the PR's description! This has been tested by being imported in an already existing controller, I will automate testing in the follow-up PRs, I decided to split it in several ones to ease up the job of the reviewers |
awesome, much appreciated @Al-Pragliola /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
The InferenceService reconcile function is responsible for managing the lifecycle of Model Registry InferenceService entities, the prerequisite for an InferenceService to be associated with an MR entity is that the required labels "modelregistry.opendatahub.io/model-version-id" or "modelregistry.opendatahub.io/inference-service-id" are set, then the reconcile function will create (or get, if it already exists) a ServingEnvironment in the Model Registry whose name is the same as the namespace of the InferenceService. The reconcile function will also create (or get, if the label "modelregistry.opendatahub.io/inference-service-id" is set) an InferenceService in the Model Registry associated with the ServingEnvironment, the DesiredState will be "DEPLOYED", if the InferenceService is deleted, the reconcile function will set the DesiredState to "UNDEPLOYED".
How Has This Been Tested?
This has been tested by being imported in an already existing controller, I will automate testing in the follow-up PRs, I decided to split it in several ones to ease up the job of the reviewers
Merge criteria:
DCO
check)