Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: InferenceService reconcile function #541

Merged

Conversation

Al-Pragliola
Copy link
Contributor

@Al-Pragliola Al-Pragliola commented Nov 7, 2024

Description

The InferenceService reconcile function is responsible for managing the lifecycle of Model Registry InferenceService entities, the prerequisite for an InferenceService to be associated with an MR entity is that the required labels "modelregistry.opendatahub.io/model-version-id" or "modelregistry.opendatahub.io/inference-service-id" are set, then the reconcile function will create (or get, if it already exists) a ServingEnvironment in the Model Registry whose name is the same as the namespace of the InferenceService. The reconcile function will also create (or get, if the label "modelregistry.opendatahub.io/inference-service-id" is set) an InferenceService in the Model Registry associated with the ServingEnvironment, the DesiredState will be "DEPLOYED", if the InferenceService is deleted, the reconcile function will set the DesiredState to "UNDEPLOYED".

How Has This Been Tested?

This has been tested by being imported in an already existing controller, I will automate testing in the follow-up PRs, I decided to split it in several ones to ease up the job of the reviewers

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
@Al-Pragliola Al-Pragliola force-pushed the feat/inferenceservice-controller branch from bf7166c to fee2381 Compare November 7, 2024 16:22
Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
@Al-Pragliola Al-Pragliola marked this pull request as ready for review November 7, 2024 20:18
@google-oss-prow google-oss-prow bot requested review from tarilabs and Tomcli November 7, 2024 20:18
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @Al-Pragliola!

I assume this is tested by importing into other controllers and it's working, and that tests will be made here upstream in following PRs?

if that is correct for both, and
/lgtm
with the intent to close this PR early, to ease follow-up works/tasks

@tarilabs
Copy link
Member

/approve cancel

@Al-Pragliola
Copy link
Contributor Author

Thank you very much @Al-Pragliola!

I assume this is tested by importing into other controllers and it's working, and that tests will be made here upstream in following PRs?

if that is correct for both, and /lgtm with the intent to close this PR early, to ease follow-up works/tasks

thanks @tarilabs yes exactly as you said, I have updated the PR's description!

This has been tested by being imported in an already existing controller, I will automate testing in the follow-up PRs, I decided to split it in several ones to ease up the job of the reviewers

@tarilabs
Copy link
Member

thanks @tarilabs yes exactly as you said, I have updated the PR's description!

This has been tested by being imported in an already existing controller, I will automate testing in the follow-up PRs, I decided to split it in several ones to ease up the job of the reviewers

awesome, much appreciated @Al-Pragliola

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants