Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add golangci-lint timeout to fix CI #504

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

Griffin-Sullivan
Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan commented Oct 21, 2024

Description

Adding a golangci-lint config file to increase our timeout, so we won't get failures in CI. Setting the timeout to 3m (default is 1m). Open to discussion if 3m is too big or too small.

How Has This Been Tested?

Changed timeout to something really short (1ms) and got:

ERRO Timeout exceeded: try increasing it by passing --timeout option 

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Signed-off-by: Griffin-Sullivan <gsulliva@redhat.com>
Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

@lucferbux: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tarilabs
Copy link
Member

@tarilabs
Copy link
Member

@ederign
Copy link
Member

ederign commented Oct 28, 2024

Thanks for this, Griffin; let's try with 3 minutes. if it's not enough we can revisit this later.

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ederign, lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ederign
Copy link
Member

ederign commented Oct 28, 2024

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Oct 28, 2024
@google-oss-prow google-oss-prow bot merged commit ab714cf into kubeflow:main Oct 28, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants