-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add golangci-lint timeout to fix CI #504
Conversation
Signed-off-by: Griffin-Sullivan <gsulliva@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@lucferbux: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for this, Griffin; let's try with 3 minutes. if it's not enough we can revisit this later. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign, lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Description
Adding a golangci-lint config file to increase our timeout, so we won't get failures in CI. Setting the timeout to 3m (default is 1m). Open to discussion if 3m is too big or too small.
How Has This Been Tested?
Changed timeout to something really short (1ms) and got:
Merge criteria:
DCO
check)If you have UI changes