Add displayName and description to GetServiceDetails #486
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add displayName and description when we get service details from the cluster. This is based off of the fact that we expect MR or the user deploying the MR service to add the
displayName
anddescription
toannotations
on the service.How Has This Been Tested?
make run PORT=4000 MOCK_K8S_CLIENT=false MOCK_MR_CLIENT=false
curl http://localhost:4000/api/v1/model_registry
. You should see the BFF log a couple errors because you will be missing a displayName and descriptiondisplayName
anddescription
to the service annotations by running:Merge criteria:
DCO
check)If you have UI changes