-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(csi): prevent race condition in ci tests step #426
fix(csi): prevent race condition in ci tests step #426
Conversation
Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
7b2d9c2
to
89fa54f
Compare
cc @lampajr |
Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @Al-Pragliola this is great and cc @lampajr for awareness and in case this "pattern" of the sleep is used in other places?
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @Al-Pragliola, it looks great to me!!!
@tarilabs the only other place where we could use the same approach is here
model-registry/csi/test/e2e_test.sh
Lines 171 to 175 in e0598fd
sleep 5 | |
SERVICE_HOSTNAME=$(kubectl get inferenceservice sklearn-iris -n $KSERVE_TEST_NAMESPACE -o jsonpath='{.status.url}' | cut -d "/" -f 3) | |
res=$(curl -s -H "Host: ${SERVICE_HOSTNAME}" -H "Content-Type: application/json" "http://${INGRESS_HOST}/v1/models/sklearn-iris:predict" -d @/tmp/iris-input.json) | |
echo "Received: $res" |
iirc I introduced the 5s sleep because sometimes the res
was not populated.. but I don't rembember if it was failing in retrieving SERVICE_HOSTNAME
or the res
directly. So I think this could be done as a follow-up PR if needed.
Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
791d832
to
4f3003c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks @Al-Pragliola !
/lgtm
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lampajr, tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
fixes a race condition found in the ci CSI tests: https://github.com/opendatahub-io/model-registry/actions/runs/10997757515/job/30534062040#logs
How Has This Been Tested?
run the ci
Merge criteria:
DCO
check)