Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving all non-public packages to internal #401

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

ederign
Copy link
Member

@ederign ederign commented Sep 19, 2024

Moving all non-public packages to internal

Description

The goal of this PR is to move all non-public packages to internal

How Has This Been Tested?

Run the BFF, Run the FE, built the docker image.

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Tests are all passing, running locally does fine, and I even tested the new image inside a kind cluster:

curl http://localhost:4000/api/v1/healthcheck
{
        "status": "available",
        "system_info": {
                "version": "1.0.0"
        }
}
curl http://localhost:4000/api/v1/model_registry
{}

@ederign
Copy link
Member Author

ederign commented Sep 20, 2024

@tarilabs Alex is on PTO. Do you mind merging this?

@alexcreasy
Copy link
Contributor

/lgtm

@alexcreasy
Copy link
Contributor

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexcreasy, Griffin-Sullivan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 5eb1166 into kubeflow:main Sep 23, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants