Add Registered Model View #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-oss-prow
bot
requested review from
alexcreasy,
andreyvelich and
ederign
lucferbux
force-pushed
the
mod-arch-10682
branch
3 times, most recently
from
263e317 to
37e8529
Compare
Griffin-Sullivan
approved these changes
Sep 18, 2024
| { | ||
| title: 'View details', | ||
| // eslint-disable-next-line @typescript-eslint/no-empty-function | ||
| onClick: () => {}, // TODO: @Griffin-Sullivan uncomment this once model versions is active ---> navigate(`${rmUrl}/${ModelVersionsTab.DETAILS}`), |
| @@ -0,0 +1,95 @@ | |||
| import * as React from 'react'; | |||
| import { Flex, FlexItem, Stack, StackItem, TextInput } from '@patternfly/react-core'; | |||
| import { Modal } from '@patternfly/react-core/deprecated'; | |||
There was a problem hiding this comment.
I'm also hitting this in my current PR that's not up yet. Will we want to update all of our Modals in a future sprint?
ederign
approved these changes
Sep 18, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign, Griffin-Sullivan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@lucferbux can you please rebase this? |
Signed-off-by: lucferbux <lferrnan@redhat.com>
lucferbux
force-pushed
the
mod-arch-10682
branch
from
37e8529 to
e95a5fa
Compare
|
/lgtm |
This was referenced Sep 19, 2024
This was referenced Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Added both unit testing and integration testing. As well ass runing the backend in mock mode.
Merge criteria:
DCOcheck)If you have UI changes