Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm update and versions bumps #374

Merged
merged 1 commit into from
Sep 11, 2024
Merged

npm update and versions bumps #374

merged 1 commit into from
Sep 11, 2024

Conversation

ederign
Copy link
Member

@ederign ederign commented Sep 10, 2024

Description

  • Regenerated package-lock.json due to node major version bump.
  • Removed victory types
  • Bump @typescript-eslint/eslint-plugin
  • Bump @typescript-eslint/parser

How Has This Been Tested?

npm install
npm run start:dev

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

No ui changes.

@github-actions github-actions bot added Area/UI and removed size/XXL labels Sep 10, 2024
@ederign
Copy link
Member Author

ederign commented Sep 10, 2024

@Griffin-Sullivan, there is a severe vulnerability listed on npm audit related to serve . AFAIK, this is just a dev dependency used by cypress. I'm watching this issue waiting for response from maintainers. (/cc @tarilabs )

@ederign ederign closed this Sep 10, 2024
@ederign ederign reopened this Sep 10, 2024
ederign
ederign commented Sep 10, 2024
View reviewed changes
clients/ui/frontend/.eslintrc
@@ -72,7 +72,6 @@
"no-only-tests/no-only-tests": "error",
"@typescript-eslint/default-param-last": "error",
"@typescript-eslint/dot-notation": ["error", { "allowKeywords": true }],
"@typescript-eslint/lines-between-class-members": ["error", "always"],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Griffin-Sullivan https://eslint.org/blog/2023/10/deprecating-formatting-rules/

not sure if we should add something in Prettier to cover that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a rule I already didn't care for too much any way. For now we can just remove

ederign
ederign commented Sep 10, 2024
View reviewed changes
clients/ui/frontend/src/__tests__/unit/testUtils/hooks.ts
@@ -7,14 +7,8 @@ import {
} from '@testing-library/react';
import { queries, Queries } from '@testing-library/dom';

export type BooleanValues<T> = T extends
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier asked for one line.

clients/ui/frontend/src/__tests__/unit/testUtils/hooks.ts
| undefined
// eslint-disable-next-line @typescript-eslint/ban-types
| Function
// eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as this is a test, I just ignore the warning. @Griffin-Sullivan please let me know if we should refactor it instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine with me

clients/ui/frontend/src/__tests__/unit/testUtils/hooks.ts
@@ -174,7 +168,7 @@ export const createComparativeValue = <T>(source: T, booleanTarget: BooleanValue

const createComparativeValueRecursive = <T>(
source: unknown,
// eslint-disable-next-line @typescript-eslint/ban-types
// eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

clients/ui/frontend/src/components/browserStorage/BrowserStorageContext.tsx
@@ -122,7 +122,7 @@ export const BrowserStorageContextProvider: React.FC<BrowserStorageContextProvid
setValues((oldValues) => ({ ...oldValues, [storageKey]: storageValue }));

return true;
} catch (e) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complaining about unused var

This was referenced Sep 10, 2024
Closed
Closed
Closed
@ederign
Npm update and versions bumps
cfbcc1f 
Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>

Regenerating package-lock.json

Removing @types/victory@35.0.0 since looks like it's not needed'

bump @typescript-eslint/parser: ^7.18.0

bump typescript-eslint/parser
@ederign ederign changed the title Npm update npm update and versions bumps Sep 10, 2024
Griffin-Sullivan
Griffin-Sullivan reviewed Sep 10, 2024
View reviewed changes
Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me. When I have some time tomorrow morning I'm gonna try installing this branch and see how it looks on install. Thanks for doing this Eder!

clients/ui/frontend/src/__tests__/unit/testUtils/hooks.ts
| undefined
// eslint-disable-next-line @typescript-eslint/ban-types
| Function
// eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine with me

Griffin-Sullivan
Griffin-Sullivan approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Install worked fine for me. Let's merge this one.

@alexcreasy
Copy link
Contributor

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Sep 11, 2024
@alexcreasy
Copy link
Contributor

/approve

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexcreasy, Griffin-Sullivan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit a11747e into kubeflow:main Sep 11, 2024
15 checks passed
@tarilabs tarilabs mentioned this pull request Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Griffin-Sullivan Griffin-Sullivan Griffin-Sullivan approved these changes

@alexcreasy alexcreasy Awaiting requested review from alexcreasy

@andreyvelich andreyvelich Awaiting requested review from andreyvelich

Assignees

@alexcreasy alexcreasy

Labels
approved Area/UI lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ederign @alexcreasy @Griffin-Sullivan