-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add info about installing extras #373
docs: add info about installing extras #373
Conversation
Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @isinyaaa wdyt?
extra (available as `model-registry[hf]`). Reference section "[installing extras](#installing-extras)" above for | ||
more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addresses the comment from #370
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great Matteo! I'd just add that remark also on the error string under model_registry.ModelRegistry.register_hf_model
e.g.:
Co-authored-by: Isabella Basso <isabellabdoamaral@gmail.com> Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
Co-authored-by: Isabella Basso <isabellabdoamaral@gmail.com> Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
7ff4113
to
fc6b750
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: isinyaaa, rareddy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Resolves #370
How Has This Been Tested?
Merge criteria:
DCO
check)If you have UI changes