-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup Jest for frontend unit testing #314
Conversation
clients/ui/frontend/package.json
Outdated
"@testing-library/user-event": "14.4.3", | ||
"@types/jest": "^29.5.12", | ||
"@types/jest": "^28.1.8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Griffin-Sullivan do we need to downgrade those versions? Can we start with the most recent ones?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry not sure why I changed those. Might have happened when I was debugging and I was just using what ODH had. It's working fine with the versions we had so I changed it back.
Signed-off-by: Griffin-Sullivan <gsulliva@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Ok no particular feedback on this one, tested and it's working, we'll start porting testUtils when we start implementing model registry.
@lucferbux: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign, lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Signed-off-by: Andrew Block <andy.block@gmail.com>
Signed-off-by: Griffin-Sullivan <gsulliva@redhat.com>
Description
Adding the unit testing directory and dependencies for Jest unit testing. I would like to rebase this off of #290 when it's merged so I can update the github actions for testing the frontend.
Again a lot of this is carried over from ODH and removed some things that don't apply to us.
How Has This Been Tested?
npm run test:unit
npm run test:jest
npm run test:cypress-ci
andnpm run start:dev
to ensure there's no regressions.Merge criteria: