Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Jest for frontend unit testing #314

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

Griffin-Sullivan
Copy link
Contributor

Description

Adding the unit testing directory and dependencies for Jest unit testing. I would like to rebase this off of #290 when it's merged so I can update the github actions for testing the frontend.

Again a lot of this is carried over from ODH and removed some things that don't apply to us.

How Has This Been Tested?

npm run test:unit
npm run test:jest
npm run test:cypress-ci and npm run start:dev to ensure there's no regressions.

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

"@testing-library/user-event": "14.4.3",
"@types/jest": "^29.5.12",
"@types/jest": "^28.1.8",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Griffin-Sullivan do we need to downgrade those versions? Can we start with the most recent ones?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry not sure why I changed those. Might have happened when I was debugging and I was just using what ODH had. It's working fine with the versions we had so I changed it back.

Signed-off-by: Griffin-Sullivan <gsulliva@redhat.com>
Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Ok no particular feedback on this one, tested and it's working, we'll start porting testUtils when we start implementing model registry.

Copy link

@lucferbux: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Ok no particular feedback on this one, tested and it's working, we'll start porting testUtils when we start implementing model registry.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ederign, lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ederign
Copy link
Member

ederign commented Aug 27, 2024

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Aug 27, 2024
@google-oss-prow google-oss-prow bot merged commit 7e645e0 into kubeflow:main Aug 27, 2024
14 checks passed
dhirajsb pushed a commit to dhirajsb/model-registry-kfp that referenced this pull request Aug 30, 2024
Signed-off-by: Andrew Block <andy.block@gmail.com>
Al-Pragliola pushed a commit to Al-Pragliola/model-registry that referenced this pull request Sep 3, 2024
Signed-off-by: Griffin-Sullivan <gsulliva@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants