Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHA: trigger CSI tests on go.mod update #313

Merged
merged 1 commit into from
Aug 27, 2024
Merged

GHA: trigger CSI tests on go.mod update #313

merged 1 commit into from
Aug 27, 2024

Conversation

isinyaaa
Copy link
Contributor

This prevents CSI dependencies from being out-of-date.

Description

How Has This Been Tested?

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@isinyaaa
GHA: trigger CSI tests on go.mod update
80672ad 
This prevents CSI dependencies from being out-of-date.

Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com>
tarilabs
tarilabs reviewed Aug 27, 2024
View reviewed changes
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

.github/workflows/csi-test.yml Show resolved Hide resolved
@google-oss-prow google-oss-prow bot added the lgtm label Aug 27, 2024
@tarilabs
Copy link
Member

many thanks Isabella, will wait for another to go in then proceeding to merge this one

lampajr
lampajr reviewed Aug 27, 2024
View reviewed changes
Copy link
Member

@lampajr lampajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

.github/workflows/csi-test.yml Show resolved Hide resolved
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 03dd3cd into kubeflow:main Aug 27, 2024
14 checks passed
@isinyaaa isinyaaa deleted the push-vmornuymzxok branch August 27, 2024 14:45
@tarilabs tarilabs mentioned this pull request Aug 28, 2024
Merged
Al-Pragliola pushed a commit to Al-Pragliola/model-registry that referenced this pull request Sep 3, 2024
@isinyaaa @Al-Pragliola
GHA: trigger CSI tests on go.mod update (kubeflow#313)
045871a 
This prevents CSI dependencies from being out-of-date.

Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lampajr lampajr lampajr left review comments

@tarilabs tarilabs tarilabs approved these changes

@andreyvelich andreyvelich Awaiting requested review from andreyvelich

@rareddy rareddy Awaiting requested review from rareddy

Assignees

@tarilabs tarilabs

@lampajr lampajr

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isinyaaa @tarilabs @lampajr