Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tips section to README.md #287

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

tonyxrmdavidson
Copy link
Contributor

…o adds informaiton on a known issue regarding DB deployment and how to mitigate it when it happens

Change 'Known Isues' to 'Tips'

This commit will change the title of the section of the README to Tips

Change Title to Generic Reference

This commit will change the title from Model-Registry-db mysql:8.3.0 to use a generic title which will reflect that pull image rate limiting is not confined to mysql:8.3.0

Change Description of Issue

This commit will change the description to use the model-registry-db container issue as an example to demonstrate image rate limiting.

Specify Error Description is an Example

This commit will expand the description of the error to show it is an example of a wider issue.

Description

How Has This Been Tested?

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

…o adds informaiton on a known issue regarding DB deployment and how to mitigate it when it happens

Signed-off-by: tonyxrmdavidson <tonyxrmdavidson@yahoo.co.uk>

Change 'Known Isues' to 'Tips'

This commit will change the title of the section of the README to Tips

Co-authored-by: Matteo Mortari <matteo.mortari@gmail.com>

Change Title to Generic Reference

This commit will change the title from Model-Registry-db mysql:8.3.0 to use a generic title which will reflect that pull image rate limiting is not confined to mysql:8.3.0

Co-authored-by: Matteo Mortari <matteo.mortari@gmail.com>

Change Description of Issue

This commit will change the description to use the model-registry-db container issue as an example to demonstrate image rate limiting.

Co-authored-by: Matteo Mortari <matteo.mortari@gmail.com>

Specify Error Description is an Example

This commit will expand the description of the error to show it is an example of a wider issue.

Co-authored-by: Matteo Mortari <matteo.mortari@gmail.com>
@tarilabs tarilabs changed the title This PR will add a Known Issues section to the README.md file. It als… Add Tips section to README.md Aug 21, 2024
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks @tonyxrmdavidson

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 092a689 into kubeflow:main Aug 21, 2024
11 checks passed
dhirajsb pushed a commit to dhirajsb/model-registry-kfp that referenced this pull request Aug 30, 2024
likely due to HF maintenance of model ids
located at the root-level
Al-Pragliola pushed a commit to Al-Pragliola/model-registry that referenced this pull request Sep 3, 2024
Change 'Known Isues' to 'Tips'

This commit will change the title of the section of the README to Tips



Change Title to Generic Reference

This commit will change the title from Model-Registry-db mysql:8.3.0 to use a generic title which will reflect that pull image rate limiting is not confined to mysql:8.3.0



Change Description of Issue

This commit will change the description to use the model-registry-db container issue as an example to demonstrate image rate limiting.



Specify Error Description is an Example

This commit will expand the description of the error to show it is an example of a wider issue.

Co-authored-by: Matteo Mortari <matteo.mortari@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants