Adds description and display name properties to mocked ModelRegistry responses #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcreasy
force-pushed
the
mr-selector-endpoint
branch
from
d60888d to
f4ec86d
Compare
…y endpoint response for mocked data Signed-off-by: Alex Creasy <alex@creasy.dev>
alexcreasy
force-pushed
the
mr-selector-endpoint
branch
from
f4ec86d to
9ac3548
Compare
ederign
approved these changes
Aug 15, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
dhirajsb
pushed a commit
to dhirajsb/model-registry-kfp
that referenced
this pull request
Aug 30, 2024
…sts on a mac with M2 (kubeflow#272) resolved comments from isinyaaa and tarilabs Update wording and explanations after resolved comments from isinyaaa and tarilabs
Al-Pragliola
pushed a commit
to Al-Pragliola/model-registry
that referenced
this pull request
Sep 3, 2024
…responses (kubeflow#272) Signed-off-by: Alex Creasy <alex@creasy.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the
GET /api/v1/model-registryendpoint will now return description and display name when using mocked out data.How Has This Been Tested?
make run PORT=4000 MOCK_K8S_CLIENT=truecurl localhost:4000/api/v1/model-registry/displayNameanddescriptionpropertiesMerge criteria: