Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: BFF is able to run (mocked) without Kubernetes #190

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

ederign
Copy link
Member

@ederign ederign commented Jul 15, 2024

In this PR:

  • Kubernetes client mock
  • Update on BFF readme

Description

To make it easy for front-end and BFF developers to run FE and BFF without Kubernetes, I've created a simple mocked client that returns a model registry and points the service to localhost:8080 (where docker-compose is running).

How Has This Been Tested?

Please go through README.md to double-check if everything works as expected.

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

In this PR:
- Kubernetes client mock
- Update on BFF readme

Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
@ederign
Copy link
Member Author

ederign commented Jul 15, 2024

@alexcreasy, please double-check if you can onboard with the BFF just reading the instructions?

@alexcreasy
Copy link
Contributor

@ederign I've run this with MOCK_K8S_REQUESTS=true enabled and it works nicely, I'm able to make the requests against the API as listed in the README without any errors.

Just to note, I ran this using podman desktop with docker compose compatibility enabled, without any issues.

@ederign
Copy link
Member Author

ederign commented Jul 16, 2024

@tarilabs, we are ready to review!

Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks #190 (comment)
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 1d37fa5 into kubeflow:main Jul 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants