Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misleading reference to DELETE operations in OpenAPI schema #63

Closed
dmartinol opened this issue Apr 12, 2024 · 2 comments · Fixed by #182
Closed

Misleading reference to DELETE operations in OpenAPI schema #63

dmartinol opened this issue Apr 12, 2024 · 2 comments · Fixed by #182
Assignees
@tarilabs
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers lifecycle/stale

Comments

@dmartinol
Copy link

Describe the bug
The OpenAPI schema includes the DELETE operation for some of the managed paths, but delete services are not really implemented.

To Reproduce
See an example of misleading description here.

Note that there is no delete operation under these paths.

Also, if we try to curl -X DELETE, it returns HTTP/1.1 405 Method Not Allowed

Expected behavior
Either implement the described operations or fix the documentation.
@dmartinol dmartinol added the bug Something isn't working label Apr 12, 2024
@tarilabs
Copy link
Member

Thank you for reporting this @dmartinol ; as explained, Google ML-Metadata (which Model Registry is based on), does not support deletion semantic. We get support only of status change. As you correctly say, the description should be reflected.

The OpenAPI schema includes the DELETE operation for some of the managed paths, but delete services are not really implemented.

There is no entry in OpenAPI for delete: verb in https://github.com/kubeflow/model-registry/blob/main/api/openapi/model-registry.yaml

This is to be reflected basically in all textual documentation.

@tarilabs tarilabs added documentation Improvements or additions to documentation good first issue Good for newcomers labels Apr 12, 2024
dhirajsb pushed a commit to dhirajsb/model-registry-kfp that referenced this issue May 22, 2024
@tarilabs
Enhance GHA to check uncommitted changes (kubeflow#63)
b27dc7c 
* Enhance GHA to check uncommitted changes

* Test GHA output deliberately

* Revert "Test GHA output deliberately" used for GHA testing

This reverts commit 065eb59ebad105ff891e3ff256c0645a50107f84
which was used for GHA testing
tarilabs pushed a commit to tarilabs/model-registry that referenced this issue Jun 19, 2024
@tonyxrmdavidson
Merge pull request kubeflow#63 from tonyxrmdavidson/ubiImageUpdate
674d429 
This commit will update the registry.access.redhat.com/ubi8/ubi-minimal image tag
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@tarilabs tarilabs assigned tarilabs and unassigned ichuniq Jul 15, 2024
@tarilabs tarilabs mentioned this issue Jul 15, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tarilabs tarilabs

Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers lifecycle/stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

openapi: wrong ref to delete, list GET and PATCH tarilabs/model-registry
3 participants
@tarilabs @ichuniq @dmartinol