-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Context name containing characters requiring url quoting/escaping #255
Labels
Milestone
Comments
isinyaaa
added a commit
to isinyaaa/model-registry
that referenced
this issue
Aug 22, 2024
Fixes: kubeflow#255 Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
3 tasks
isinyaaa
added a commit
to isinyaaa/model-registry
that referenced
this issue
Aug 26, 2024
Fixes: kubeflow#255 Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
isinyaaa
added a commit
to isinyaaa/model-registry
that referenced
this issue
Aug 27, 2024
Fixes: kubeflow#255 Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
dhirajsb
pushed a commit
to dhirajsb/model-registry-kfp
that referenced
this issue
Aug 30, 2024
…eflow#255) Bumps [github.com/go-chi/chi/v5](https://github.com/go-chi/chi) from 5.0.10 to 5.0.11. - [Release notes](https://github.com/go-chi/chi/releases) - [Changelog](https://github.com/go-chi/chi/blob/master/CHANGELOG.md) - [Commits](go-chi/chi@v5.0.10...v5.0.11) --- updated-dependencies: - dependency-name: github.com/go-chi/chi/v5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
isinyaaa
added a commit
to isinyaaa/model-registry
that referenced
this issue
Aug 30, 2024
Fixes: kubeflow#255 Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
isinyaaa
added a commit
to isinyaaa/model-registry
that referenced
this issue
Aug 30, 2024
Fixes: kubeflow#255 Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
isinyaaa
added a commit
to isinyaaa/model-registry
that referenced
this issue
Sep 2, 2024
Fixes: kubeflow#255 Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
thank you @isinyaaa |
Al-Pragliola
pushed a commit
to Al-Pragliola/model-registry
that referenced
this issue
Sep 3, 2024
* converter: simplify MapName Signed-off-by: Isabella do Amaral <idoamara@redhat.com> * converter: restrict captures to prefix when mapping *FromOwned Fixes: kubeflow#255 Signed-off-by: Isabella do Amaral <idoamara@redhat.com> * py: make: fix build-mr tagging Signed-off-by: Isabella do Amaral <idoamara@redhat.com> * py: tests: introduce regression testing Signed-off-by: Isabella do Amaral <idoamara@redhat.com> * py: make: expose IMG_* env vars Signed-off-by: Isabella do Amaral <idoamara@redhat.com> --------- Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Unable to index ModelVersion containing
:
.To Reproduce
Steps to reproduce the behavior:
following the kubeflow tutorial, example:
,
Expected behavior
Can use special characters without having to
urllib.parse.quote()
manually the version name.i.e. without requiring to:
Additional context
This is likely deriving from the fact that in the Model Registry Python client, the logical model entity attributes are passed to the rest layer without quote where sometimes might be necessary; for example, when the model version name is used as a query parameter in a rest endpoint call.
It could be a helpful exercise to check if any limitations on MLMD side for Context names themselves (we are aware MLMD Context names are not updatable, but that is an unrelated limitation).
The text was updated successfully, but these errors were encountered: