Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dockerSockPath to argo config map #550

Closed
wants to merge 1 commit into from
Closed

add dockerSockPath to argo config map #550

wants to merge 1 commit into from

Conversation

adrian555
Copy link
Member

@adrian555 adrian555 commented Oct 21, 2019

Which issue is resolved by this Pull Request:

Since Argo v2.4.0, new config dockerSockPath is added to allow different location of docker.sock. Ref. argoproj/argo-workflows#1419.
To reflect the change in Argo and to better support different docker installation, add the dockerSockPath to the Argo config map.

Description of your changes:

Add dockerSockPath to argo base config map and related kustomization yaml as well as the tests.

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate
    3. make test

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @adrian555. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hougangliu
Copy link
Member

/ok-to-test

@@ -135,6 +135,7 @@ data:
{
executorImage: $(executorImage),
containerRuntimeExecutor: $(containerRuntimeExecutor),
dockerSockPath: $(dockerSockPath),
Copy link
Member

@hougangliu hougangliu Oct 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now, Kubeflow installs v2.3.0 argo. does dockerSockPath work for v2.3.0?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hougangliu this just adds one config to the workflow-controller-configmap which is not used in v2.3.0. It does not break argo workflow functionality. I have tested this with a fresh install of kubeflow 0.6.2 and run the sample pipeline successfully.

@hougangliu
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hougangliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adrian555
Copy link
Member Author

/retest

@k8s-ci-robot
Copy link
Contributor

@adrian555: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
kubeflow-manifests-presubmit 2846e37 link /test kubeflow-manifests-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stale
Copy link

stale bot commented Jun 2, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in one week if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale label Jun 2, 2020
@stale
Copy link

stale bot commented Jun 9, 2020

This issue has been closed due to inactivity.

@stale stale bot closed this Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants